Prioritizing full name vs username in the UX

[sam (Sam Saffron)]

I just added a site setting that allows you to prioritize full names as opposed to usernames in the UI.

When usernames are prioritized cause the site setting prioritize_username_in_ux is enabled you will see:

In card:

On user page:

In post stream:

If you change it so prioritize_username_in_ux is disabled you will see:

In card:

On user page:

In post stream:

I feel an @ symbol may be worth adding per:

This can be done safely via CSS, leaving it off for now.

Quotes inside the UX still pull in username eg:

@sam

Eg: this quote is going to sam: as opposed to sam saffron:

We may look at making this switch to be fullname based when the setting is set.

[riking (Kane York)]

Bug report: If full name is blankish, username is offset and not fully bold

[mcwumbly (Dave McClure)]

eh?

Full name @mentions

It would look more elegent in posts if @leo (for example) was presented as (or at least the user had the option to present it as) “Leo” or “Leo McArdle”.

[sam (Sam Saffron)]

corrected per

https://github.com/discourse/discourse/commit/0e2d918b3b3807041126bc66d3e0d205d42c7820

Still abusable, but we might as well correct that server side by doing a trim on save that is unicode aware.

[sam (Sam Saffron)]

That is a can-of-worms to implement, same class as improving quotes. I may get to it, but not for this round.

[gerhard (Gerhard Schlager)]

@sam

I feel an @ symbol may be worth adding per:

https://d11a6trkgmumsb.cloudfront.net/original/3X/d/0/d0c5b1049a0693259beec3cd229052dff5e07abd.png

I believe the username should be shown with @ by the default. It’s a lot less confusing.

And the username should always be visible. Don’t make me think.

[codinghorror (Jeff Atwood)]

At symbol too noisy repeated all over the page. In the user card should suffice.

[jerry0 (Jerry)]

This is working in almost all places, but not in email notifications.

So, in e.g. user card it looks fine.

But in email notifications full name is not prioritized:

(also I think only one of the two names need be hyperlinked, the first I guess)

[sam (Sam Saffron)]

@techAPJ can you investigate a fix for emails?

[techAPJ (Arpit Jalan)]

Fixed via:

FIX: respect prioritize_username_in_ux setting in email

When prioritize_username_in_ux is enabled:

When prioritize_username_in_ux is disabled:

[techAPJ (Arpit Jalan)]

Further simplified the styling to use same CSS for username and user-name. (notice the bold font-weight for username vs the normal for user-name.)

UX: use same styling for username and user-name

[techAPJ (Arpit Jalan)]

Pushed another fix here for /about page:

FIX: respect `prioritize_username_in_ux` setting on /about page

[mentalstring (Paulo)]

I found a place where this setting doesn’t seem to be taking effect: the list of username matches on search results:

Geminiscp is the username and prioritize username in ux = true.

[debryc (Deborah Chang)]

We just installed the experimental sidebar and chat. Can full names be prioritized in the Personal chat section as well if we disable prioritize_username_in_ux?