Questions about GitHub bug fix commits and tests-passed


(Lutz Biermann) #1

I hope this is the correct category for this question. I am new and trying to understand what you are doing.

Speaking about Permissions buttons not working

This fix (and others from today) goes into the master branch but not into tests-passed. So if you are like me on the latest beta, you won’t get all the super fast bugfixes ? Or does it just take some time, for automated testing, till it shows up at tests-passed? if so, how long does it take - hours, days, weeks?

Thank you so much and keep up the great work!


(Régis Hanol) #2

Every time there’s a new commit on master, our build server will run all the test suites.
If they all pass, it will merge the changes to test-passed.

It usually takes less than 15 minutes, unless we break the tests… :wink:


Regression in UI in default theme
(Lutz Biermann) #3

Thank you very much for explaining!

So you guys broke the tests, because test-passed is 9 hours/10 commits behind master :slight_smile: Understood.


(cpradio) #4

No, based on the below URL and the green checkmarks, the tests passed. Not sure how often tests-passed gets updated though or if there is a problem with that part of the process.
Commits · discourse/discourse · GitHub


(Régis Hanol) #5

There actually was something wrong with the script merging master to test-passed :wink:

It’s now fixed and test-passed is up to date.


(Régis Hanol) #6