Quick access to bookmarks and messages on user menu

A bug - clicking Log Out takes you to your user summary, unable to successfully sign out:

6 Likes

I can confirm @nexo’s bug report here on meta.

On my sites I don’t seem to have this person tobiaseigen menu yet - clicking on it just takes me to my activity page.

3 Likes

Thanks, I just pushed a fix! Updating the theme component should do it.

Could you try updating Discourse? You will need to be on latest Discourse for the person / profile quick access tab, specifically this commit from two days ago.

8 Likes

That was quick work - the fix works!

Arrgh. I should have known to try that first. :slight_smile: But yes, updating discourse worked and now this functionality works on my site.

Thank you! :rocket:

6 Likes

How about a custom links setting in the theme component? I can see this being super useful for every site with SSO to provide dashboard links relevant only to logged in members. On my site I just replaced a custom header with the Brand header theme component which is working great, and future proof too with no customizations! Now would also like to be able to add an “Edit profile” linking to wordpress that is also future proof.

3 Likes

You may make all notifications under tabs scrollable. It’s redirecting to another page even for a quick peek.

Really like the new design! With the new bookmarks tab maybe it’s worth having some sort of indicator for the author of the post or some other identifying info? Maybe before it in plain text in a similar way to how names in other notifications/messages look? Would help when you have a bunch of bookmarks from the same topic.

7 Likes

Yea that makes sense! I have pushed an update for this, thanks!

I am actually preparing a PR to fold this into core right now. After it’s included in core, I imagine it shouldn’t be too hard to have another theme component that adds custom links there!

12 Likes

It works just fine (made an update). Very comfortably!
Many thanks to everyone! :+1:

3 Likes

This is now in core as of the update I made this morning, so the theme component must be removed to avoid duplicate tabs and weirdness showing up in the menu. Once removed and browser hard refresh all is well. Nice work - this is a fabulous improvement to discourse.

12%20AM

9 Likes

Thanks @Stranik @tobiaseigen! The PR was only just merged around the time you updated!

Thanks for the heads-up! I am going to deprecate the theme component with an update (i.e. wipe it out + some console messages).

I originally thought about keeping it so instances on stable can also try out the feature, but I realized it depends on some other new changes in core, so it essentially only works on tests-passed.

8 Likes

I’m really excited this is finally merged! :heart:

That would be a waste :sob:

That theme component is a fantastic example of how to wire things up correctly in the context of themes.

Since we just released a new beta, you can use that to nullify the component based on Discourse version via the maximum_discourse_version. Check this out Adding metadata to a theme

11 Likes

Wow TIL thanks! Tried this out locally and it is so cool!

10 Likes

Wow! This is and looks amazing! Well done.

3 Likes

Amazing work, Kyle! :clap:


I noticed a minor issue here, it looks like the Messages and Assigned tabs are having trouble rendering every row with single / double quotes. I’m seeing this on Firefox, Windows if that helps.

Messages

image

Assigned

image

Bookmarks & Notifications
These two tabs can render quotes just fine :ok_hand:

Any ideas?

7 Likes

Nice catch! I just submitted a PR to fix this in core (another will follow shortly for assignment).

Special characters are escaped before being rendered, however, fancy_title is already escaped. Escaping it again would print the HTML entity as-is, e.g. " instead of the desired " .

10 Likes

Should the group inboxes also be under the PM tab? I keep expecting them to be there.

3 Likes

That would not be my expectation, no.

To clarify, I would expect that tab to just be messages directed specifically to me.

2 Likes

Yeah I guess that’s a logical distinction… the disconnect for me might be that all the messages are under the envelope icon on my profile, but not in my notification menu (the sidebar under messages on profiles does split them out, so the UI is just different overall).

6 Likes

12 posts were split to a new topic: Improving the layout of the user menu tab