Really like the new design! With the new bookmarks tab maybe it’s worth having some sort of indicator for the author of the post or some other identifying info? Maybe before it in plain text in a similar way to how names in other notifications/messages look? Would help when you have a bunch of bookmarks from the same topic.
Yea that makes sense! I have pushed an update for this, thanks!
I am actually preparing a PR to fold this into core right now. After it’s included in core, I imagine it shouldn’t be too hard to have another theme component that adds custom links there!
It works just fine (made an update). Very comfortably!
Many thanks to everyone!
This is now in core as of the update I made this morning, so the theme component must be removed to avoid duplicate tabs and weirdness showing up in the menu. Once removed and browser hard refresh all is well. Nice work - this is a fabulous improvement to discourse.
Thanks for the heads-up! I am going to deprecate the theme component with an update (i.e. wipe it out + some console messages).
I originally thought about keeping it so instances on
stable can also try out the feature, but I realized it depends on some other new changes in core, so it essentially only works on
I’m really excited this is finally merged!
That would be a waste
That theme component is a fantastic example of how to wire things up correctly in the context of themes.
Since we just released a new beta, you can use that to nullify the component based on Discourse version via the
maximum_discourse_version. Check this out Adding metadata to a theme
Wow TIL thanks! Tried this out locally and it is so cool!
Wow! This is and looks amazing! Well done.
Amazing work, Kyle!
I noticed a minor issue here, it looks like the Messages and Assigned tabs are having trouble rendering every row with single / double quotes. I’m seeing this on Firefox, Windows if that helps.
Bookmarks & Notifications
These two tabs can render quotes just fine
Nice catch! I just submitted a PR to fix this in core (another will follow shortly for assignment).
Special characters are escaped before being rendered, however,
fancy_title is already escaped. Escaping it again would print the HTML entity as-is, e.g.
" instead of the desired
That would not be my expectation, no.
To clarify, I would expect that tab to just be messages directed specifically to me.
Yeah I guess that’s a logical distinction… the disconnect for me might be that all the messages are under the envelope icon on my profile, but not in my notification menu (the sidebar under messages on profiles does split them out, so the UI is just different overall).
12 posts were split to a new topic: Improving the layout of the user menu tab
There’s a new, minor issue with the assign quick access tab. The text is jet black instead of the usual blue color:
Took a quick look and opened a PR to fix this: