Triple-clicking the last (or only) paragraph in a post does not toggle the “Quote” button, at least for me in Chrome 57.0.2987.133.
It looks like this has been fixed previously, but may have resurfaced.
OK so this is a particular thing that I tend to do over and over, I double click paragraphs while I’m reading and the reply button doesn’t actually show up if I select the last paragraph. Presumably because chrome’s selection thing randomly includes bits of the chrome too (it seems to select a little bit after the newline, highlighting at the start of the ‘like’ heart). I don’t know if this is fixable or worth fixing but I thought it should be reported.
Another thing I’d like is a user-option t…
…so you probably can’t triple-click this text to quote it in a new reply.
3 Likes
dax
(Daniela)
May 1, 2017, 3:43pm
2
You’re right, it’s relating to Chrome. With Firefox there’s no problem, triple click works very well.
4 Likes
Sujan
(Jan P.)
May 9, 2017, 10:25am
3
Same on Chrome in ChromeOS:
Version 57.0.2987.148 (64-bit)
Plattform 9202.66.0 (Official Build) stable-channel falco
Firmware Google_Falco.4389.92.0
1 Like
sam
(Sam Saffron)
May 9, 2017, 1:33pm
4
I think this is only the last paragraph, I believe @zogstrip worked on making this more robust in the past, looks like there is an edge case.
zogstrip
(Régis Hanol)
May 9, 2017, 1:35pm
5
I think @tgxworld removed/changed my fix. I don’t recall why though
1 Like
tgxworld
(Alan Tan)
May 9, 2017, 1:45pm
6
Which commit was it? I definitely did not remove it intentionally.
zogstrip
(Régis Hanol)
May 9, 2017, 1:46pm
7
1 Like
tgxworld
(Alan Tan)
May 9, 2017, 1:49pm
8
Ah that commit was fixing the quote button appearing when highlighting the “like” count text. I’ll have a look.
zogstrip
(Régis Hanol)
May 9, 2017, 1:53pm
10
When triple-clicking the last paragraph, the selection spans over the .cooked
div and starts selecting content from the .post-menu-area
section.
This is why I added these lines
https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/lib/utilities.js.es6#L92-L94
It’s the most reliable way I could find. There’s one thing I didn’t try: adding a .quotable
div inside the .cooked
div and ensure only that div is selectable.
But another fresh pair of won’t hurt
3 Likes
tgxworld
(Alan Tan)
May 9, 2017, 1:56pm
11
Yea I’ll have to look through the code path again since it has been awhile.
4 Likes
tgxworld
(Alan Tan)
May 11, 2017, 8:52am
12
7 Likes
tgxworld
(Alan Tan)
Closed
May 13, 2017, 10:00am
13
This topic was automatically closed after 2 days. New replies are no longer allowed.