Quote reply not working in IE 11

bug
1

When using IE 11 highlighting text does not reveal the “quote” pop up. It works fine in chrome and I confirmed myself that this doesn’t work in IE 11. Apparently we support back to IE 10.

When you highlight text these errors show up in the console:

image.png945×260 22.5 KB

2 Likes
2

Related to
https://github.com/discourse/discourse/commit/ce9fe213fdfd0a90bc8ed0e67b518bf34fd18762

5 Likes
5

This is quite bad, @eviltrout can you fix this, seems pretty straight forward to use jQuery closest here as opposed to DOM closest

1 Like
7

I think this should fix it

const withinCooked = $(range.startContainer.parentNode).closest('.cooked');

Haven’t tested though.

1 Like
8

Even edge does not support native Closest until very latest version so this should be avoided.

http://caniuse.com/#feat=element-closest

Per the wikipedia Edge release history it looks like “Edge 15” is only released as of April 11, 2017.

9

Not working with my obscure webkit browser either.

ii  libjavascriptcoregtk-1.0-0:i386     2.4.11-3     i386       
ii  libwebkitgtk-1.0-0:i386             2.4.11-3     i386
hi  surf                                0.6-1        i386

When I highlight text, the browser spits out this console error:

** Message: console message: https://d11a6trkgmumsb.cloudfront.net/assets/application-09c15314fa7c40b3b300d2faf6824148ef6d3356ac149ccde164b442a25aa9c3.js @20: TypeError: undefined is not a function (evaluating ‘r.startContainer.parentNode.closest(".cooked")’)

(Thanks everybody.)

10

Fixed in

https://github.com/discourse/discourse/commit/dfc9a27dc4d6881555b982f913ad78e59461a2a3

I’ll need to test it out on IE11 once it gets deployed.

4 Likes
11

This topic was automatically closed after 23 hours. New replies are no longer allowed.