Found a small bug (race condition?) @sam. Two different users can assign the topic at the same time.
Not much we can do here sadly, we allow already assigned topics to be assigned to somebody new.
1 Like
This is not a new person though it is the same person.
3 Likes
Ahh did not notice that, I guess we can error out here.
2 Likes
pr-welcome for:
- IF topic is already assigned
- AND you are attempting to assign to the same person already assigned
- RAISE A non 400 error “Topic is already assigned to XYZ” and display to client.
- Test on both mobile and desktop
- Include a controller test at least in the PR
4 Likes
Hi,
I will try to submit PR for this.
Thanks
8 Likes
This is fixed now.
https://github.com/discourse/discourse-assign/commit/a2e7fc4cace440114e73ad4ab85f650a9ab30dea
6 Likes
This topic was automatically closed after 34 hours. New replies are no longer allowed.