Random 404 errors when editing posts

Bug
1

I’ve been getting random 404 errors when editing replies in my forum.

When edits work, they send a PUT request to the endpoint /posts/:post_id with a 200 response.

But when they don’t work, I can see in the developer tools a PUT request to /post_replies/:post_id that returns a 404. When I refresh the page, the errors go away and I’m able to save the edit correctly (via /posts/:post_id, the :post_id doesn’t change).

I’m not sure if there is a special condition that could make /posts turn into /post_replies by mistake or if it’s a different problem. I recently quadrupled my server’s RAM and I haven’t seen anything weird in the logs.

Any help is appreciated.

2 Likes
2

I continue to get these random errors when trying to save an edit for other people’s posts. It happens with both old and new posts, but always randomly:

image
image842×210 16.3 KB

And it goes away when I refresh the page and save the edit:

image
image755×209 15.5 KB

3

I’m on the latest version and can confirm this is still happening: trying to save an edit on other another user’s post randomly triggers a dialog box with a not_found message:

The requested URL or resource could not be found.

If I reload the page and press the “Save Edit” button again, the error goes away and the edit is saved.

4

Those two requests are getting PUT to different URLs.

5

Right. But why? I’m pressing the same “Save Edit” button in the same post. The only difference is a page refresh

6

Maybe try checking the browser backtrace next time it happens? Since it’s hitting different endpoints it may be going via different methods in the EmberJS app.

1 Like
7

@Falco It just happened again. This is all I see when I open the console after I get the error:

image
image943×48 9.92 KB

And if I try saving again with the console open:

image
image767×942 161 KB

Then I refresh the page and it lets me edit:

image

This is the path of the initiator (VM73:1 Script):

image
image546×914 118 KB

1 Like
8

I just updated to 2.7.0.beta2 and it’s still happening:

  • Try to edit post reply 47994
  • PUT https://mydomain.com/post_replies/47994 => 404 The requested URL or resource could not be found. In console: Failed to load resource: the server responded with a status of 404 () /post_replies/47994:1
  • Reload the page
  • Try to edit post reply 47994
  • PUT https://mydomain.com/posts/47994 => 200 success

If there’s any other information that would help debug it, I’d be happy to provide it.

9

This happened 3 times today in less than an hour :sweat_smile:

Is there anything else I could do to help track this bug down?

10

@Falco I finally figured out how to consistently reproduce this bug:

  1. Disable enable filtered replies view
  2. Click on the arrow on a reply: image
  3. Click on the arrow to jump to the original message: image
  4. Click on the edit icon: image
  5. Make a change and hit “Save changes”. You’ll get a dialog box saying that the URL or resource wasn’t found (404).
4 Likes
12

Thanks @Nacho_Caballero, the specific steps were very helpful. I have a PR up with a fix: https://github.com/discourse/discourse/pull/12504

7 Likes
13

No problem! Such an easy fix :sweat_smile:

3 Likes
15

As usual thank you for your patience with us Nacho – when you provide very detailed repros we can almost always whip up a fix!

4 Likes