Reassigning to a group creates a /u/ link in the @group mention

Canapin · May 3, 2023, 10:21am

It’s a small bug in the official Assign plugin.

Steps to repro:

Assign a topic to yourself
Click “Unassign…”
Click “Edit assignment…”
Choose a group and click “Edit”
The @group mention from the small action message links to /u/ instead of /g/.

For example:

@cherries here links to /u/cherries instead of /g/cherries.

It only happens in reassigns, not in assigns.

Arkshine · May 3, 2023, 2:34pm

It looks like it misses api.addGroupPostSmallActionCode("reassigned_group"); here:

github.com

discourse/discourse-assign/blob/69cbe1f3eeca90fb7207a47ecd265376d2142f18/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js#L975-L980


      
          withPluginApi("0.12.2", (api) => {
            api.addGroupPostSmallActionCode("assigned_group");
            api.addGroupPostSmallActionCode("unassigned_group");
            api.addGroupPostSmallActionCode("assigned_group_to_post");
            api.addGroupPostSmallActionCode("unassigned_group_from_post");
          });

Related Discourse code:

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/widgets/post-small-action.js#L12-L27


      
          export function actionDescriptionHtml(actionCode, createdAt, username, path) {
            const dt = new Date(createdAt);
            const when = autoUpdatingRelativeAge(dt, {
              format: "medium-with-ago-and-on",
            });
          
          
  let who = "";
            if (username) {
              if (groupActionCodes.includes(actionCode)) {
                who = `<a class="mention-group" href="/g/${username}">@${username}</a>`;
              } else {
                who = `<a class="mention" href="${userPath(username)}">@${username}</a>`;
              }
            }
            return htmlSafe(I18n.t(`action_codes.${actionCode}`, { who, when, path }));
          }

github.com

discourse/discourse/blob/main/app/assets/javascripts/discourse/app/widgets/post-small-action.js#L82-L84


      
          export function addGroupPostSmallActionCode(actionCode) {
            groupActionCodes.push(actionCode);
          }

Canapin · May 3, 2023, 2:43pm

I added this line on my dev install and it indeed seems to fix the issue

sam · May 4, 2023, 12:37am

Awesome, would you be able to submit a PR

Arkshine · May 4, 2023, 1:51pm

Sure!

github.com/discourse/discourse-assign

FIX: Reassigning to a group creates an incorrect mention's link

discourse:main ← Arkshine:fix/invalid-group-link-in-post-action

opened 01:50PM - 04 May 23 UTC

Arkshine

+1 -0

_Reported here_: https://meta.discourse.org/t/reassigning-to-a-group-creates-a-u…-link-in-the-group-mention/263659 Reassigning to a group creates an `/u/` link in the `@group` mention instead of `/g/`. ![image](https://user-images.githubusercontent.com/360640/236219080-e01f5d29-43a1-48b2-92a7-08bcbd02f4a1.png) The reason is the `reassigned_group` group small post action code is not registered, thus creating a user link by default. Related Discourse code: https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/widgets/post-small-action.js#L12-L27 https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/widgets/post-small-action.js#L82-L84

sam · May 5, 2023, 12:01am

Thanks @Arkshine !!!

sam · May 7, 2023, 10:00pm

This topic was automatically closed after 2 days. New replies are no longer allowed.

Topic		Replies	Views
Styling on assignment comments changed to look public ux assign	9	488	February 16, 2023
Discourse Assign Plugin plugin official , assign	5	35386	October 26, 2023
Assign topics to non-staff users feature assign	27	4530	July 7, 2021
Weird bug with discourse-assign bug assign	8	490	September 12, 2023
Bad group assignment count bug assign	10	774	July 11, 2023

Reassigning to a group creates a /u/ link in the @group mention

Related Topics