Reply doesn't clear the edit post text if clicked after Edit


(Dan Dascalescu) #1
  1. Edit your own post
  2. Click “Reply” to it.

Note how the contents of the post edit textarea isn’t cleared for the reply.

Executon in the other order, Reply then Edit, works correctly.


(Sam Saffron) #2

Yeah its a regression, in the past we used to display “are you sure you want to stop editing” or something like that.


(Jeff Atwood) #3

I don’t think we ever did handle this, actually – I thought you opened a bug on this.


(Alan Tan) #4

https://github.com/discourse/discourse/pull/3649

Ok so I looked into this and discovered a few more “bugs” which I included the fix in the PR.

  1. Click reply, Add some text, Click edit, Nothing happens.

  2. Click reply, Add some text, hide the composer, Click edit, Composer shows up as Reply.

  3. Not fixed yet and I’m not sure if this is considered a bug Click edit, Update the text, Click another post’s edit, Nothing happens.

cc @eviltrout since you wrote most of the composer’s code.


(Jeff Atwood) #5

Excellent, thanks for following up on these!


(Alan Tan) #6

One more PR before we can close this :smile:

https://github.com/discourse/discourse/pull/3691


(Alan Tan) #7

@zogstrip Thanks for reviewing :smile: Lets close this? :cat:


(Régis Hanol) #8