Reply then edit to add quote notification redundancy

When someone replies to you while quoting you, you get two notifications: one for the reply and one for the quote. Is this intended? It seems a bit redundant to me.

5 Likes

Yeah this is not intended and borderline a bug…

Can you confirm you got 2 notifications here?

3 Likes

I didn’t here, but maybe that’s because you replied to the topic and not another post. I did have this issue on another reply from you five days ago:

image

As well as from someone else earlier today:

image


Did you get two notifications from this reply? I think it happens every time (again barring the reply to topic).

1 Like

This is a direct reply not to the topic.

I totally believe it is happening, just want an exact repro.

I only got a reply notification… That’s weird. So I guess it doesn’t happen every time, though I see it quite often.

I don’t see any difference between your reply here and the ones that caused the issue before. They are both replies to the previous post (non-topic) with quotes from the same post. Here are links to the two I referenced above if you can spot a difference.

Beginners Guide to Install Discourse on Windows 10 for Development

`min ratio to crop` site setting should respect w/h ratio as defined in markdown

The only other thing I can think of is that the quote notifications seem to be delayed sometimes, generally coming after the reply notification. If those notifications come from a background task, maybe there’s some kind of race condition.

3 Likes

Yeah this very much feels like a race condition to me.

3 Likes

Doesn’t it happen when you first just reply, and then edit with a quote afterwards?

4 Likes

It does happen in those cases, but I doubt only in those cases. It happens often enough that it seems unlikely that that many people are adding quotes on edit. Perhaps @sam can confirm if he wrote the post I referenced at once or edited it after the fact with a quote. If he remembers since it was 6 days ago at this point.

I just got this as well for this reply/quote, screenshot:

3 Likes

In that case I did first reply, and then saved and then almost immediately edited to add the quote to give better context. So that would explain two notifications - once for the reply, and then for the quote when I edited it.

3 Likes

Ah, thanks, that would explain it then.

1 Like

I still wonder if there’s some kind of race condition where quotes made in the original reply (not on edit) can be treated like a quote added on edit. Just from the timing that is.

I only got one notification for this quote/reply. That doesn’t rule out the race condition entirely, but this is more likely the scenario Falco mentioned, i.e. replying then editing quickly to add a quote.

5 Likes

So we need to ask users not to do this :slight_smile:

It does seem to happen as an afterthought. You write a post quickly and submit it, but then you realize the context may not be entirely obvious and go back to add the quote.

Now that the “quote on edit” aspect has been mentioned I’ve been paying more attention, and I’ve been quoted several times without getting the quote notification. So it does appear likely related to that. Unfortunately I can’t really verify anything on my own since I’m not going to ask someone if they added the quote on edit every time I get the quote notification.

If it really does only happen on edit (and never from a race condition), it’s actually kind of a nice “feature” because it lets you know that more was added to a post even if you already read it.

5 Likes