tpetrov
(Toni Petrov)
November 13, 2020, 4:08pm
1
I wanted to write about that but saw it was raised already
I agree that it’s not necessary by default because it’s a short form, but it’s bad that we do two different things when custom fields are present. We do already have a class in there when custom fields are present, so I think it’s an easy change to show asterisks for all required fields in that case.
In short when you have custom fields that are required they show with asterisk, but the main fields e.g. email, username… don’t have it although they are also required, which is a bit confusing.
5 Likes
I have a pull request for this ready for review here:
https://github.com/discourse/discourse/pull/11356
This may not be merged for a week or two because we’re preparing for our next major release and changes that aren’t immediately necessary are on hold.
I’ll update when this topic when it’s been merged.
5 Likes
The above change has been merged in, so you’ll see the fields marked as required the next time your site is updated.
4 Likes
awesomerobot
(Kris)
Split this topic
November 12, 2024, 2:36pm
4
A post was split to a new topic: Recent changes to the signup form