Search help doesn't work for some locales

bug
1

Continuing the discussion from Search help doesn't work in RU locale:

The same happens to me when I use DE locale, then the help button from the search doesn’t work. When I switch over to EN locale it works flawless. Any ideas how to fix that? Do I have to translate something?

1 Like
2

No need to translate anything. This is a bug.
AFAIK the search help works only for English, all other languages result in an Error 404 when https://meta.discourse.org/static/search_help.html is requested.

4 Likes
3

I did look into this issue. This seems to be a problem with the localization fallback.
The translation is available, but it looks like I18n.exists? doesn’t use the fallback.

https://github.com/discourse/discourse/blob/d37c2a2c98a83eb65b7fe520a8ffcdddc1207299/app/controllers/static_controller.rb#L39-L42

@riking I’m not sure how to solve this. Can you please take a look at this?

4 Likes
4

Well, it works for zh_CN. https://meta.discoursecn.org/ It’s v1.4.0.beta11 +93

5

Yes, it works, because the translation for static.search_help exists for zh_CN.
I corrected my post in the other topic:

2 Likes
6

Just added the German locale for that string on Transifex - as an “incremental fix” for this bug… :smile:

3 Likes
7

This should fix it for all languages:
https://github.com/discourse/discourse/pull/3792

5 Likes
8

This topic was automatically closed after 24 hours. New replies are no longer allowed.