Searching email logs doesn't find emails in cc:

Bug
1

We were trying to find records of outbound email to a user, but they only show up when you explicitly search for group_smtp emails. This is counterintuitive and confusing for the admin:

The image shows a search result interface displaying a list of two descriptions with email addresses, timestamps, and placeholders for user, reply key, and email type, all with blurred text for privacy. (Captioned by AI)
The image shows a search result interface displaying a list of two descriptions with email addresses, timestamps, and placeholders for user, reply key, and email type, all with blurred text for privacy. (Captioned by AI)1781×699 56.9 KB

^ you can see here a normal search for jose shows normal results

The image shows a screen displaying an email search interface. (Captioned by AI)
The image shows a screen displaying an email search interface. (Captioned by AI)1780×281 51.7 KB

^ but a search for brian returns nothing

The image shows an email dashboard with green highlighted headers indicating messages from "brian@" within a group_msmtp filter, sorted by age, with an additional group_msmtp message in the "4 days" section. (Captioned by AI)
The image shows an email dashboard with green highlighted headers indicating messages from "brian@" within a group_msmtp filter, sorted by age, with an additional group_msmtp message in the "4 days" section. (Captioned by AI)1783×754 60.5 KB

^ until you search with email type: group_smtp

class Admin::EmailController < Admin::AdminController
  def sent
    email_logs = EmailLog.joins(<<~SQL)
      LEFT JOIN post_reply_keys
      ON post_reply_keys.post_id = email_logs.post_id
      AND post_reply_keys.user_id = email_logs.user_id
    SQL

    email_logs = filter_logs(email_logs, params, include_ccs: params[:type] == "group_smtp")

I suspect this is only here as an attempted query optimisation but I don’t think it’s necessary; it only creates this unexpected situation.

2 Likes
4

quick fix?

2 Likes