Second occurrence of inline expansion footnote cannot be expanded

bug
1

Using the footnote plugin v0.1 with settings “enable markdown footnotes” and “display footnotes inline” enabled on discourse 2.6.0 beta6 (66ecefba52) :

  • when the same inline footnote is used 2 times in a post, the first one can be clicked and expands to show the footnote, but the second does not (nor does the third…).
  • reproduced on my site with the minimal example provided on the Discourse footnote post :

We are our choices. [^sartre]
A lot of interesting words
He really said it. [^sartre]

[^sartre]: We are our choices.
Sartre, some time
some day
in the past

  • Tried to reproduce on try.discourse.org but the footnote plugin does not seem available

Can someone reproduce as well or is there a problem with my site ?

1 Like
2

I’ve tested that example on my local dev site (running the latest Discourse code with the Chrome browser.) I’m finding that the second footnote is positioned either at the bottom of the page, or off the page.

If I try inserting a unique footnote between the two duplicate footnotes, the second of the duplicate footnotes will display the content of the unique footnote if it is clicked after having clicked the unique footnote. Example markup for that issue:

We are our choices. [^sartre]

A lot of interesting words

Second footnote test [^second]

He really said it. [^sartre]

[^sartre]: We are our choices.
Sartre, some time
some day
in the past

[^second]: this is the content of the second footnote
2 Likes
3

I ran into this today, by trying to be humorous.[^one]

[^one]: You can read this, but you can’t expand this[^two].

[^two]: What a pity! This is hilarious.

4

I guess this Discourse doesn’t use the footnote plugin.

So… I infer that it’s up to me if I want this to work. Is that so? Can anyone give me a leg up?

5

First step is figuring out if it works here:

We are simply repackaging it, it is possible it is already improved in the latest release.

1 Like
6

I finally had time to look into this. Thank you for the suggestion.

markdown-it and markdown-it-footnote behave as I’d expect. I confirmed this with some simple unit tests.

The problem seems to arise when I try to click on the footnote in a topic. Here is what it’s like for me.

First, I try to click the “…” in the nested footnote, which reloads the page; then I try to click the “[2]” link in the nested footnote, for which there is no corresponding HTML anchor.

What can I do about this?

Many thanks.

1 Like