Signup CTA is not working

Bug
1

I am running on the latest Discourse version ( v2.3.0.beta7 +7).

enable signup cta

Show a notice to returning anonymous users prompting them to sign up for an account.

Signup cta has been enabled on my site. However it is not working at all. I logged out of my account. I have been browsing the site for almost 10 minutes and reading different topics. I even closed and reopened the browser to visit the site again for reading 10 minutes of different topics. Still no luck.

Any suggestions? :slightly_frowning_face:

2

Is your site invite only? Or do you have must_approve_users enabled? Iā€™m unable to reproduce the issue here.

https://github.com/discourse/discourse/blob/acd1693dac1bff6ff50250d942134bc48a27ff14/app/assets/javascripts/discourse/initializers/signup-cta.js.es6#L23-L26

I think we should display signup cta even if must_approve_users enabled. :thinking:

5 Likes
3

Sure that seems reasonable make it so.

4 Likes
4

Done. https://github.com/discourse/discourse/commit/ca57e18f42967414bd34db12e0e1425eeb75d857

4 Likes
5

I have must_approve_users option enabled on my site.

Thank you @codinghorror and @vinothkannans. :+1:

5 Likes