Some feedback on big list settings component

ux
1

Continuing the discussion from Better handling of site settings with large amount of content (big lists):

Hi there,

couple thoughts on this feature after spending some time with it in auto-linkify theme. :slight_smile:

  1. The width of the existing fields is a bit too narrow and does not match the width of the input field (tested on Latest Firefox and Chromium on Linux Mint):

image

  1. It would be nice if the whole content was displayed on hoover.

  2. Maybe I am just stupid, but it already happened to me at least twice that I typed in several entries, but then forgot to click on the green checkmark, navigated away from the theme and then was super-surprised that I lost what I typed in.
    I know this behaviour is consistent with how other settings work, but wouldn’t it make sense in this case to autosave, especially given how much one can loose? Note that it is extra confusing cause when I hit enter after typing, a new field is created and I intuitively expect it to stay there.

Yep, this is also quite confusing.

3 Likes
2

hi, thanks for feedback:

  1. is supposed to take full width, thats probably a recent regression or something else

  2. if 1 is working I feel like it’s not really needed. But Im not against this.

  3. (and4) are mostly results of how site settings work and would require to change a lot of things

5 Likes
3

Thanks, got it.

Regarding 3., I think part of the issue is that green checkmark appears at the top of the list so if you have a lot of entries it is easier to miss. It might help if it appeared right next to the input field, but I get how that could be less visually pleasing.

:thinking: Hmm, and it wouldn’t work anyway if you edited already existing entries so never mind I guess…

3 Likes
4

I am against auto save, but a general fix we should make to ALL site settings is:

If you mess with site settings and try to navigate to a new page we should display “you have changed the FOO site setting and not applied your change, navigate to a new page?” In a modal.

8 Likes
5

Would be great to have this on user preferences as well. Been bit by forgetting to save once or twice :smiley:.

6 Likes
7

was about to fix 1) but it’s coming from this recent commit https://github.com/discourse/discourse/commit/fc4a6ca7241467bd3345444d8d7e9ba79eeb61c2 which is adding style on <input> directly, can you have look please @awesomerobot ?

4 Likes
8

I just pushed this simple fix https://github.com/discourse/discourse/commit/da8916aecd573466de50c4765c11c39ae6bd0271

5 Likes
9

Yes — just changed it so it only applies to checkboxes/radio inputs, it didn’t need to be that broad.

4 Likes
10

Awesome, thanks @awesomerobot and @joffreyjaffeux! Just upgraded, works great! :+1:

Yes, that would be awesome!

6 Likes