Staff tags cause duplicate tag index

Bug
1

Continuing the discussion from ActiveRecord::RecordNotUnique on idx_tag_users_ix1: How to fix?:

The error was reproduced. I think I’m on a trail to figure this bug out.

Steps to reproduce

  1. Create a tag #foo

  2. Limit tag #foo usage to Staff

    image
    image891×141 10.4 KB

  3. Create a group Bar

  4. Assign a Watching notification of tag #foo for group Bar

  5. Have a non-privileged user join group Bar

  6. and change their personal notification for #foo to Normal

  7. Non-privileged user should be unable to read a page anymore

I suspect this is what is happening, since it happened twice to different people. The error goes like this: https://oxygen.offdem.net/logs/show/f70207d3affa8967932b9122d2be212b

Maybe the title is a bit limiting. I think it has more to do with tag restriction to groups and personal notifications.

2

All new users now have a duplicate entry which must be removed from the console:

 r = TagUser.connection.execute("SELECT user_id, tag_id, count(*) FROM tag_users GROUP BY tag_id, user_id HAVING count(*) > 1")
r.values.each { |uid,tag,_| TagUser.where(user_id: uid, tag_id: tag).last.destroy }
3

I’m not sure I’m doing the repro right…

  • Create tag group
  • Create #staff-tag tag in tag group
  • Set ‘Tags are visible to everyone, but only the following groups can use them’ to staff

  • Create group
  • On /manage/tags, add #staff-tag to Watching
  • Add test user (TL2) to group
  • Confirm #staff-tag is Watching for test user in Preferences/Tracking

  • Navigate to /tags/staff-tag and change bell icon to 'Normal`

Everything seems to work?

4

I’m not sure about this step. I used the group notifications to add the tag in the watching notifications for the group

5

I meant this page here:

image
image1047×538 17.1 KB

I maybe over-abbreviated the link - /g/GROUPNAME/manage/tags

Or do I need to try from another spot?

6

I don’t know really. I cannot spend much time on it before OFFDEM. For now I’m running the SQL requests to fix the issue for new users as they come. Maybe I overlooked a detail. Like… All categories are muted by default, that might affect the notifications.

7

That may be relevant. Are you using the mute all categories by default setting for that?

1 Like
8

Yes I do use this setting.