Два больших пальца вверх

nat · 28.Октябрь.2022 11:36:06

Исправление здесь. Должно появиться скоро!

github.com/discourse/discourse

FIX: Evaluate all callbacks rather than override them (#18788)

main ← multiple-post-menu-button-callbacks

merged 02:13AM - 31 Oct 22 UTC

nattsw

+30 -23

When we have multiple plugins triggering ``` api.removePostMenuButton("like"…, () => x); ``` the last plugin that makes the call gets to decide if the post menu button is removed or not. This change makes it such that we will evaluate all callbacks rather than just rely on the last one. Essentially, we ended up with duplicate like buttons when the discourse-upvotes plugin evaluates after discourse-reactions. <img width="354" alt="Screenshot 2022-10-28 at 7 33 19 PM" src="https://user-images.githubusercontent.com/1555215/198577684-add9e90d-7523-4595-8680-216add1cfe84.png"> Related: https://meta.discourse.org/t/thumbs-up-twice/240867/

Тема		Ответов	Просм.
Changes to which reactions :thumbsup: are counted as likes :heart: Announcements reactions	46	3204	27.05.2024
Notice: testing Discourse Reactions here on meta for 1 week! Feature	85	8764	14.04.2021
Discourse Reactions Plugin official , reactions , included-in-core	66	42321	05.10.2026
Thumbs-up - three names, one emoji UX reactions	12	1624	11.09.2023
Post Voting has likes enabled but they won't appear Bug reactions , post-voting	9	1313	10.08.2023

Два больших пальца вверх

Связанные темы