martin
2 januari 2025 om 02:22
6
This should fix the report issue:
main ← fix/report-i18n
merged 03:05AM - 02 Jan 25 UTC
Our bulk report endpoint uses `hijack`, which does not
use the current user's l… ocale via the `with_resolved_locale`
method in `ApplicationController`. This is happening because
we are doing `around_action` to set the locale, then calling
the code in the block inside the action directly when we use
`hijack`.
We can fix this by capturing `I18n.locale` when starting the
hijack then using `I18n.with_locale` when evaluating the
block inside `hijack`, this way the translations will always
use the correct locale based on the current user.
c.f. https://meta.discourse.org/t/titles-on-graphs-in-community-health-dashboard-are-not-localized/302776/5
For the “In Reply To” issue, it looks like our Czech translations are a bit lacking, our German server.de.yml file has user_notifications.in_reply_to but server.cs.yml does not. Translations fall back to English when keys are missing.
5 likes