Yeah, as above, most thumbnailing logic is now in Discourse. I actually override to loosen the inclusion requirement slightly, but it still may be stricter than before.
I’m wary of overriding any more and really the ‘looseness’ of the criteria for considering something worthy of thumbnailing should now be a core issue. TLP should really just be a customer of that data.
OK now picked up here: Problems with thumbnails from Soundcloud and YouTube oneboxes
Well, the initial issue is likely because of https://github.com/discourse/discourse/commit/03818e642a1ae871bffdc0c39c10f05f0b8b0398 where it seems thumbnail can be only uploads now. Discourse always first in breaking behavior/changes. Sorry for being salty, it’s just frustrating. 
I get it it now depends on Discourse behavior. Thanks for the help.
Just telling my status on this. Still struggling.
I’ve tried to normalize img html to include only src attribute since it seems to be ignored by discourse. For example usually a post from WP would start to contain this (here I’ve already cleaned the html, no attributes except src). The criteria you’re talking about does not seems to be related.
<div data-wp><a href="https://www.aliexpress.com/item/4000096717124.html" target="_blank"><img src="https://zuzu.deals/wp-content/uploads/2020/05/5ebd241f6e871-150x150.jpg" /></a><div><div data-buy>
Then rebaking (so image are downloaded) from the console would work only for some topics.
Typically the topic where I’ve extracted the HTML above is ignored. Whatever rake posts:rebake or in rails post.save! ; post.rebake! ; the topic is ignored. I can’t see a reason why it fails, it has the same html as the others topics which worked.
However, if I edit manually from composer without changing the content and saving, then the image is extracted/downloaded. There are too much topics to edit manually.
Do you have an idea how you could achieve the same saving as composer does with rails console?
Note: the max old days option is set to the maximum value
That’s a very interesting, if frustrating, difference in behaviour. Can I suggest you post that as a Support Topic as that’s not really in scope of the plugin?
Huge troubles here after adding an image to a topic.
Can’t access this topic : https://forum.cwowd.com/t/oceans-par-north-star-games-livraison-vf-juin-2020/5221
Can’t find it via search (Internal server error) with eg oceans or north star
Tags used for this topic = Error 500
Category used for this topic = https://forum.cwowd.com/exception (I can access to Unread etc.)
Main pages (lastest or categories) = Error 500.
Got this bug this morning, could not find any solution and rolled back to last backup. Tried to change image and got again Errors 500/exception/ISE etc.
Why do you think this involves TLP? TLP does not change any code related to access to Topics.
Uninstall TLP (remove it from app.yml). Rebuild. What do you see now?
Did this start after an upgrade? Consider testing everything in a staging environment first before updating Production.
We only support Production upgrades in the first 5 days of the month.
because we got these errors, retored old backup (everything was fine) then changed again the thumbmail from the same topic and everything “crashed”
both times using the octopus image of this Kickstarter link
from first post of this topic :
Please remove TLP and see if error goes away.
Also check logs, what error are you seeing if any in /logs?
I can access that Topic fine now? Oceans - par North Star Games - livraison VF juin 2020 - Jeux financés - cwowd.com
This is not a valid category url: cwowd.com https://forum.cwowd.com/exception
I’m not convinced this has anything to do with TLP …
yes, we rolled back to previous backup
this is the page discourse redirectioned for “faulty” category (Jeux financés - cwowd working fine since rollback)
I could try to bug it again same way but my sys admin will sure charge me a few hundred euros if I try… (and I’d not blame him for doing so^^)
btw, no saying this plugin is faulty (error implied some s3 stuff). Just that using that particuliar image as thumbnail caused some weird behavior from discourse. Maybe it is, maybe not. This is first time it happened to me after many weeks using your plugin with full satisfaction, pretty weird
Thumbnail generation has moved to Discourse Core now. What TLP was doing to create thumbnails is now mostly done by Discourse. More and more TLP is just a presentation layer.
is there a reason why discourse is doing it now? i’m still unable to fix my site left it as is
My guess is they decided to create a Theme Gallery and that required thumbnails (because presenting too many images at their original resolution would have made the page very slow). And it kind of went from there …
I think we should see this as a really positive move by Discourse btw. It’s great that the platform can now generate, store and deliver thumbnail data to the Topic List more or less out of the box without the need for a plugin.
In the long run that’s going to make the platform more attractive and help stability.
After upgrading to the last version of Discourse and TPL, we see glitches in the tiles. Some of them render properly as tiles, some don’t and then we get overlapping boxes, some content hidden. You can see for yourselves at https://eqlzr.org (you may need to scroll down to see it).
The browser console explains what is going on:
Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content.
I don’t know whether this bug belongs to TLP or Discourse core.
Your site is rendering perfectly for me with both Chrome and Safari. But I can see some kind of issue in Firefox, interesting. I will take a look in more detail when I have time.
NB any issue with javascript can break the layout. This doesn’t have to be from TLP, it could be from any add-in or Discourse core as javascript ‘crashing’ will prevent TLP from finishing the layout.
76.0.1 (64-bit)
Mozilla Firefox for Ubuntu
But you are right, here it seems to work well and reliably (same laptop, same Ubuntu version):
Google Chrome
81.0.4044.113 (Official Build) (64-bit)
I have to do it individually for EVERY category?
Perfect, thank you @merefield. That’s saved some time!
Hey Robert, I’m testing out the TC on a different small site and having issues with it. I don’t have the TLP plugin installed, just the helper plugin. The Topic Thumbnails TC is working as expected which I have set for the default neutral theme on this site, I have TLPTC set for the dark theme so you can see what’s happening https://community.exploringexposure.com/ I’m on the latest of everything.
