Topic List Previews (legacy)

[merefield (Robert)]

Looks like there maybe a JavaScript error? Can you post any console errors (ignore the warnings)?

[davidkingham]

I knew I forgot something

FYI it’s nearly vanilla, your helper plugin, akismet, and calendar are the only plugins

[merefield (Robert)]

Bingo, you didn’t follow the instructions Again You need to permit the external script. This is identical to the issue you previously reported.

Topic List Previews (legacy)

Yup a JavaScript error might well stop the layout code dead. Have you updated staging and Theme Component to latest? I trust you have TLP plugin uninstalled? Oh and have you given it rights to get the required scripts? Add this to security settings: content security policy script src: https://unpkg.com This is no longer necessary, because Discourse’s funky new Theme Modifiers support modifications to CSP which is now implemented in the TC (that allows ImagesLoaded and dependencies to be d…

[davidkingham]

Ughhh! I totally forgot about that, so sorry! I was going based off this post and didn’t remember that little bit. Trying to do too many things at once

Topic List Previews (legacy)

OK I’d better summarise the current status as things are getting confusing: There are now two distinct setups: Existing, standard, Plugin based one. I’m thinking of replacing it with 2 though (I will give notice). Plugin https://github.com/paviliondev/discourse-topic-previews OR: TC based, experimental, expect minor issues but added bonuses of Featured Images on mobile and responsiveness to sidebars … optional plugin sidecar that adds features Theme Component https://github.com/me…

[merefield (Robert)]

No worries, there are so many posts and its a more complex setup than I would prefer to have. I sometimes forget.

@davidkingham I’ve modifed that post to add that detail

No longer required, see below.

[david (David Taylor)]

@merefield

You need to permit the external script

@merefield you can let people skip this step by adding it to the theme about.json

@david

• csp_extensions string array - add directives to the CSP. Works the same as the old “extend_content_security_policy” theme-setting method

[merefield (Robert)]

Awesome advice, David, thanks, I.will.do.that!

[merefield (Robert)]

Sorry David, our other David has provided an excellent solution to this and I’ve deployed it so you no longer have to worry about adding this manually Sorry for all the setup torture

[Krischan]

@merefield

Yep that could work. And perhaps a setting for latest versus created

Don’t want to be obtrusive, but is this in scope for one of the next updates? Thanks for your feedback!

[merefield (Robert)]

I can’t give a timeline, but yes, I intend to implement this.

[markersocial]

Thumbnail generation has moved to Discourse Core now. What TLP was doing to create thumbnails is now mostly done by Discourse. More and more TLP is just a presentation layer.

Just noticed that CDN urls for thumbs are working now also, yeoww!

[raghukamath (Raghavendra Kamath)]

The thumbnails for featured images are not showing up on the top row after the update. Is there something i need to do? I just have the original TLP plugin installed.

[ozkn (Mathx)]

Hi @merefield ,

topic list previews are not working after updating.

Rebake all posts?

Either one of these should work ./launcher enter app rake posts:rebake or cd /var/discourse ./launcher enter app bundle exec rake posts:rebake

I completed the rebake process.

preview images do not appear on mobile.

I use amazon s3. Is the problem due to this?

[christian_01 (Christian)]

I’ve just updated my Discourse to the latest version, and all the topic list image/thumbnails have disappeared from my site.

Is this a bug? All the plug-in settings are still good/active. ‘Excerpts’ are working okay, but images are not.

[merefield (Robert)]

Guys, you are killing me … we have published a policy of only supporting upgrades during the 1st 5 days of the month. You do so at other times at your own risk. Please DON’T upgrade during the month if you are hoping to get my prompt attention.

That said, I’ve just tested the plugin on my site, fully updated and thumbnails are generating fine.

Please make sure you are using the official repo: https://github.com/paviliondev/discourse-topic-previews

and you have rebaked all posts. Be patient for the time lag as all the processing happens. Results are not immediate.

If then you don’t see thumbnails generated and showing up in /latest.json, it’s probably not a TLP issue.

[christian_01 (Christian)]

I changed my ‘download remote images max days old to 3650’ and rebaked, and it’s looking good:

cd /var/discourse
./launcher enter app
rake posts:rebake

[raghukamath (Raghavendra Kamath)]

@merefield

Guys, you are killing me … we have published a policy of only supporting upgrades during the 1st 5 days of the month.

Sorry, didn’t mean to irritate you. Thanks for reminding of the update policy.

[merefield (Robert)]

No worries. TLP is such a large piece of software now its quite a lot to maintain. This is also true of several other Pavilion plugins, so we are trying to focus support on days 1-5 so we can attend to other priorities the rest of the time. Unless you have a staging server to perform pre-checks on, avoid the temptation of upgrading Production outside of this time if you rely on our plugins :).

If this encourages you to get a staging server up, I’ll be very pleased

[pfaffman (Jay Pfaffman)]

FWIW, I just did an upgrade that failed to bootstrap.

I added this to my app.yml right under params (there is a commented out version there). It bootstrapped and launched and seems to be working.

  version: 1a5bcf2a648caf3d277ae2b0856a566789c55e3f

[Raj_Rathore]

@merefield

No worries. TLP is such a large piece of software now its quite a lot to maintain. This is also true of several other Pavilion plugins, so we are trying to focus support on days 1-5 so we can attend to other priorities the rest of the time. Unless you have a staging server to perform pre-checks on, avoid the temptation of upgrading Production outside of this time if you rely on our plugins :).

Would it possible for you extract only the functionality of selecting thumbnail / featured image and create a separate theme component? I need only this functionality. It would be great if discourse includes this. Your implementation of selecting thumbnail is really intuitive I’m using a Fakebook theme (Renamed it to Social ), the masonry layout doesn’t seem suitable for it though and using this theme component limits the scrolling behavior… and messes up the layout. However, the only functionality required in this theme is selecting the thumbnail. Other themes have your theme component. Hopefully, you’ll soon resolve all issues, Theme component looks good though… as learned, I’ll update the pavilion themes/plugins in the first 5 days of the month