Topic List Previews

Same problem here.

After rebaking the previews now work.

But each time I have to upgrade (not under my control, each time I made a rebuild for changing something the forum is upgraded) I cross my fingers.

1 Like

Christian, if you are referring to the Plugin, they are in the Category’s own Settings (not the main admin settings).

Have added a note to the OP to make that more clear! :slight_smile:

1 Like

Criteria for thumbnail building is largely deferred to Discourse core now.

Your issue is likely to occur with any add-in component that uses Discourse thumbnails. Should they broaden their criteria?

Could you post the complete raw contents of a problem post? If I ever get time (I can’t promise anything) I’ll see if it’s trivial to broaden inclusion. However, I’m a little reluctant to override this as Discourse having implemented this in core is a good reason to avoid overrides and rely more on core. This will help stability of the plugin and reduce breaking changes. It’s exactly this kind of customisation that trips up plugins.

You could always maintain your own fork and customise this yourself?

You could try to use the thumbnail picker in the Topic Meta editor to see if you can pick the thumbnail, but that is based on the same criteria for inclusion. If the thumbnail doesn’t appear there, it is not meeting the criteria, so that would act as a good confirmation.

1 Like

This is a pretty suboptimal arrangement.

If you want to optimise stability test upgrades in a staging environment, report/resolve any issues, then update production.

Applying untested changes directly to Production is usually a bad idea.

We do our best to deliver compatibility, focusing on the first 5 days of the month, but we are a change taker, with no warning, so update Discourse the rest of the month at your own risk. And please test your upgrades in a safe environment!

2 Likes

EDIT: comment moved to Problems with thumbnails from Soundcloud and YouTube oneboxes.

2 Likes

Yeah, as above, most thumbnailing logic is now in Discourse. I actually override to loosen the inclusion requirement slightly, but it still may be stricter than before.

I’m wary of overriding any more and really the ‘looseness’ of the criteria for considering something worthy of thumbnailing should now be a core issue. TLP should really just be a customer of that data.

OK now picked up here: Problems with thumbnails from Soundcloud and YouTube oneboxes

2 Likes

Well, the initial issue is likely because of FEATURE: Include optimized thumbnails for topics (#9215) · discourse/discourse@03818e6 · GitHub where it seems thumbnail can be only uploads now. Discourse always first in breaking behavior/changes. Sorry for being salty, it’s just frustrating. :pensive:

I get it it now depends on Discourse behavior. Thanks for the help.

Just telling my status on this. Still struggling.

I’ve tried to normalize img html to include only src attribute since it seems to be ignored by discourse. For example usually a post from WP would start to contain this (here I’ve already cleaned the html, no attributes except src). The criteria you’re talking about does not seems to be related.

<div data-wp><a href="https://www.aliexpress.com/item/4000096717124.html" target="_blank"><img src="https://zuzu.deals/wp-content/uploads/2020/05/5ebd241f6e871-150x150.jpg" /></a><div><div data-buy>

Then rebaking (so image are downloaded) from the console would work only for some topics.
Typically the topic where I’ve extracted the HTML above is ignored. Whatever rake posts:rebake or in rails post.save! ; post.rebake! ; the topic is ignored. I can’t see a reason why it fails, it has the same html as the others topics which worked.

However, if I edit manually from composer without changing the content and saving, then the image is extracted/downloaded. There are too much topics to edit manually.

Do you have an idea how you could achieve the same saving as composer does with rails console?

Note: the max old days option is set to the maximum value

2 Likes

That’s a very interesting, if frustrating, difference in behaviour. Can I suggest you post that as a Support Topic as that’s not really in scope of the plugin?

1 Like

When loading /latest some of the posts are showing up as bookmarked for my profile even though I have no bookmarks. Multiple users reporting this.

Here’s a screenshot. I have no bookmarked posts yet some of the posts shows up as bookmarked:

Hovering over the bookmarked icons of one of the falsely bookmarked posts shows a tool-tip with the following:

you’ve bookmarked this post[missing %{name} value]

Clicking the bookmark icon toggles the icon to off, but doesn’t seem to actually have any effect… if I reload the page those same posts show up as bookmarked again, even though they are not.

However, if after clearing the icon state I click it once again to toggle the icon back on… then the post is actually bookmarked as a result.

We’re using Discourse 2.5.0.beta4 - https://github.com/discourse/discourse version 918bd75909d73cd5361f285d59f9b2e0db97e4ac and TLP 4.3.1

What does STR mean?

1 Like

Huge troubles here after adding an image to a topic.

Can’t access this topic : https://forum.cwowd.com/t/oceans-par-north-star-games-livraison-vf-juin-2020/5221

Can’t find it via search (Internal server error) with eg oceans or north star

Tags used for this topic = Error 500

Category used for this topic = https://forum.cwowd.com/exception (I can access to Unread etc.)

Main pages (lastest or categories) = Error 500.

Got this bug this morning, could not find any solution and rolled back to last backup. Tried to change image and got again Errors 500/exception/ISE etc.

Why do you think this involves TLP? TLP does not change any code related to access to Topics.

Uninstall TLP (remove it from app.yml). Rebuild. What do you see now?

Did this start after an upgrade? Consider testing everything in a staging environment first before updating Production.

We only support Production upgrades in the first 5 days of the month.

1 Like

Thanks for the report. I’ll take another look at bookmarking before month-end.

2 Likes

because we got these errors, retored old backup (everything was fine) then changed again the thumbmail from the same topic and everything “crashed”

both times using the octopus image of this Kickstarter link

from first post of this topic :

Please remove TLP and see if error goes away.

Also check logs, what error are you seeing if any in /logs?

I can access that Topic fine now? Oceans - par North Star Games - livraison VF juin 2020 - Jeux financés - cwowd.com

This is not a valid category url: cwowd.com https://forum.cwowd.com/exception

I’m not convinced this has anything to do with TLP …

yes, we rolled back to previous backup

this is the page discourse redirectioned for “faulty” category (Jeux financés - cwowd.com working fine since rollback)

I could try to bug it again same way but my sys admin will sure charge me a few hundred euros if I try… (and I’d not blame him for doing so^^)

btw, no saying this plugin is faulty (error implied some s3 stuff). Just that using that particuliar image as thumbnail caused some weird behavior from discourse. Maybe it is, maybe not. This is first time it happened to me after many weeks using your plugin with full satisfaction, pretty weird

Thumbnail generation has moved to Discourse Core now. What TLP was doing to create thumbnails is now mostly done by Discourse. More and more TLP is just a presentation layer.

1 Like

is there a reason why discourse is doing it now? i’m still unable to fix my site left it as is

My guess is they decided to create a Theme Gallery and that required thumbnails (because presenting too many images at their original resolution would have made the page very slow). And it kind of went from there …

I think we should see this as a really positive move by Discourse btw. It’s great that the platform can now generate, store and deliver thumbnail data to the Topic List more or less out of the box without the need for a plugin.

In the long run that’s going to make the platform more attractive and help stability.

5 Likes