November 2023 - refactoring Discovery routes: how will it affect my theme/plugin?

david · November 6, 2023, 10:47am

This change is now live in main/tests-passed

DEV: Refactor discovery routes to remove use of 'named outlets' (#22622)

committed 10:39AM - 06 Nov 23 UTC

The motivation of this PR is to remove our dependence on Ember's 'named outlets'…, which are removed in Ember 4+. At a high-level, the changes can be summarized as: - The top-level `discovery` route is totally emptied of all logic. The HTML structure of the template is moved into the `<Discovery::Layout />` component for use by child routes. - `AbstractTopicRoute` and `AbstractCategoryRoute` routes now both lean on the `DiscoverySortableController` and associated template. This controller is where most of the logic from the old top-level `discovery` controller has ended up. - All navigation controllers/templates have been replaced with components. `navigation/categories`, `navigation/category` and `navigation/default` were very similar, and so they've all been combined into `<Navigation::Default>`. `navigation/filter` gets its own component. - The `discovery/topics` controller/template have been moved into a new `<Discovery::Topics>` component. Various other parts of the app have been tweaked to support these changes, but I've tried to keep that to a minimum. Anything from `<TopicList>` down is untouched, which should hopefully mean that a large proportion of topic-list-customizing themes are unaffected. For more information, see https://meta.discourse.org/t/282816

Topic		Replies	Views
Important changes to Plugin Outlets for Ember 2.10 Dev	23	6533	June 1, 2018
(not recomended) Overriding Discourse templates from a Theme or Plugin Developer Guides how-to	11	2058	July 26, 2024
Is there a theming 'map'? (An easy way to find plugin-outlets etc) Dev	11	1896	February 7, 2020
Upgrading Ember to 2.10 Dev ember	71	10597	December 22, 2016
Setting default tag per category in a theme component Dev	3	860	October 22, 2021

November 2023 - refactoring Discovery routes: how will it affect my theme/plugin?

Related topics