Upload modal window with customisable warning / text area

andrei · July 2, 2021, 10:04am

The upload modal was removed in this PR:

FEATURE: use native file picker in composer (#13552)

committed 08:45AM - 30 Jun 21 UTC

We want to remove completely our custom modal for uploading files in composer an…d directly trigger the system file picker. This PR makes it happen. The fix is pretty simple since we already weren't using our custom modal on mobile. We just need to start using the same hidden <input type="file"> that we already use on mobile. It seems to be pretty tricky to test opening a system modal so I haven't added new tests. We already have other tests for file uploading though. We directly trigger jquery-File-Upload plugin hooks in those tests - https://github.com/discourse/discourse/blob/3dda926cb22751beced12b427dd14657b53b6dfe/app/assets/javascripts/discourse/tests/acceptance/composer-attachment-test.js#L89.

Now we just trigger system file pickers directly.

Topic		Replies	Views
Restrict uploads Theme component	16	3360	January 8, 2024
More flexible upload options for admin? Feature	6	1127	May 30, 2019
Adding text to the box that pops up after you click the Upload Button Support	2	342	September 9, 2020
[PAID] File sharing plugin Marketplace	3	1653	July 5, 2019
Is this possible ? Additional interactive editing dialog on file upload in create topic dialog Dev	0	25	August 9, 2024

Upload modal window with customisable warning / text area

Related topics