Username and timestamp at top of posts too high in latest Discourse


(Esko) #1

In the latest version of Discourse, the username and timestamp is closer to the top border of posts than the avatar, making them misaligned. The read marker is as before and thus also misaligned.

The bottom buttons in posts are 15 px from the bottom border. Avatar is 15 px from the top border.

I can only imagine this being unintentional, and you’re probably already aware of it. Didn’t know what to search for, so I apologise if already reported.


(Sam Saffron) #2

I am a bit confused, can you attach some before and after screenshots?


(Esko) #3

Hmm, do you know an unupdated Discourse forum? I’ll go look!

Compare with this:


(Sam Saffron) #4

This is 1.4.0.beta 7 … http://forum.tycoonmarket.com/t/shades-of-what-you-say/18541 looks just like it does here:

vs:

So not following what changed …


(Esko) #5

Huh. Here’s how it looks for me, and apparently another person I spoke with.

  • Firefox 44.0.2
  • OS X 10.11.3 (15D21)

It looks as it should in Safari!

Disabled all my Firefox extensions to see if any of them caused it, but they do not seem to have.


(Mittineague) #6

I don’t know how many pixels, but with Firefox and Chrome it looks to be about a 0.5em difference between the top of the avatar and “name” and “time”.

Not all that noticeable to me, especially with round avatars, but it is there.

It looks to be the .topic-body { padding: 5px 11px 2px; } vs.
topic-avatar { padding: 15px; }


(Sam Saffron) #7

I think you are complaining about this by @rubo77 :

Which imo is just too hacky anyway… I don’t really agree with this change so going to revert it, it leads to the topic view not having a consistent view and I don’t think it is needed.


(Mittineague) #8

If you wanted to save the 10px .topic-avatar could be given a “top” to match.


(Esko) #9

Remember the read tracking marker and “Reply as linked topic” too if wishing to compact it. I’d probably remove the same amount of space for the buttons at the bottom of posts as well.


#10

It should save as much height as possible on screens smaller than max-height: 700px

(sure you can simulate this on bigger screens with CTRL + to zoom)


(Sam Saffron) #11

I follow the intentions here, but don’t feel like the support weight is worth it in this case. It is easily done in a site customization.


#12

I still don’t see the problem. Where is some space missing or too much? can you show a screenshot please?


(Esko) #13

Compacted:

  • Username
  • Timestamp

Not compacted:

  • Avatar
  • Read marker
  • Reply as linked Topic

There’s a screenshot in an earlier post.


(Sam Saffron) #14

I just don’t see the value in a compacted view based on browser height… it just feels odd to me and a support burden. This was the only case where we changed behavior based on height, all other spots are based on width.


#15

On small screens you are happy about every inch you save, so you can see some more posts at the same time on your screen (in a large good readeable font)

For example, I have an 11’’ screen on my laptop and I don’t want to scroll past all these white areas between every post


(Esko) #16

I would probably not prefer the compact view even with everything properly aligned.

I use an 11″ 1366x768 display, and while I can understand the desire, I believe I disagree with having it by default.


#17

so lets take it effect a bit later, lets say smaller than 600px

this will fix the “reply as lilnked” and the time position:

.topic-meta-data .post-info {
  margin-top: -2px;
}
.gutter .post-links {
    margin-top: -5px;
}

(Sam Saffron) #18

I just feel this is much better fitting as a site customization, you can make a topic for it here with screenshots and all. If there is strong drive from the community to include it in core we can revisit this in a few months.

As it stands it just feels a bit hacky and unfinished.


#19

Usually users wouldn’t see it anyway if they have normal large screens, higher than 600px. On small screens Discourse is really hard to use.

And as visitor you cannot change the view of discourses, that you visit somewhere in the web. So the default installation should reach all users with small screens.

Sure, I really like it like this with those two rules added. What are other opinions?


(Esko) #20

Does it trigger in small windows on large displays?

Please implement it well and take good screenshots as @sam suggested. Present the whole thing and it may find its way in. I’m not wholly against it, and I understand you want it in all Discourses you visit without having to do something extra for each one. Not to mention the feature may well make sense with the right implementation. I’m just not sure yet. Convince us!