Username autocomplete does not go away after typing comma

Bug
1

Steps to reproduce:

In a topic, type “Hi @username,<enter>”

Expected result:

Text box contains “Hi @username,” and a newline. Also, the username autocompletion box should go away after typing the comma.

Actual result:

Text box contains “Hi @username” and no newline. In other words, because the autocomplete stayed open after typing the comma, the <enter> was interpreted as selecting the username from the autocomplete. This wipes out the comma, and means that no newline is inserted.

This is on hosted Discourse, so presumably the latest version. https://community.letsencrypt.org/.

Thanks very much!

3 Likes
2

Should comma interrupt here @sam? That seems sensible to me so maybe you can allocate the work.

2 Likes
3

Yeah this is a quirk we should fix, it gets super weird cause it remains in place after ,SPACE which is extra weird.

image

@dan can you add this to your list?

3 Likes
4

I have added a check on the client side to ensure that the search term is validated using same rule as on the server side (specifically UsernameValidator.username_char_valid?).

https://github.com/discourse/discourse/pull/7005

7 Likes