Username completition broken for names with accents like Régis

(Robert) #1


In my forum, people have real names with all different kind of accents. I tried to use the username completition launched by typing @ to mention a user while writing a response and found that I could not find users by their name if the name contains an é.

You can test it on your own. Try to find @zogstrip by typing @ followed by for Régis. The actual username lookup is Note that all characters from the e with accent on are stripped off from the search query.

Discourse should ignore if a character is accented when doing a search
(Sam Saffron) #2

I assume it is a similar issue for Chinese @fantasticfears ? Do you want to take sorting this out?

(Erick Guan) #3

Sure, I’ll take a look into this.

(Robert) #4

In Europe, we have quite a few countries with numerous non-ASCII first and lastnames: Máté,
Zétény, Márton, Clémence, Léonie, Aïcha, etc.

So if for instance our German and English speaking forum users try to find or tag those people without having these accents on their keyboard, one might believe the database is incomplete. They just don’t appear if you type the first few letters.

tl;dr: Having this working is really important for regions with more heterogeneous character sets.

Rails should have some helpers therefore:

1.9.3p392 :001 > require "i18n"
 => true
1.9.3p392 :002 > I18n.transliterate("Hé les mecs!")
 => "He les mecs!"

(Robert) #5

Any news? :slightly_smiling_face:

(Erick Guan) #6

Should be close. Once some code is swept, it will come to alive :slight_smile:

(Robert) #7

Related commit:

(Robert) #8

I found a related topic:

The bug can still be reproduced. Régis cannot be tagged if you know not his lastname or his username @zogstrip. :frowning:

(Régis Hanol) #9

This works now. @eviltrout fixed it recently :+1:


And the request is

(Régis Hanol) #10