Welcome message images not showing up for non-English languages


(Tenzan) #1

Hi all,

I’ve just setup brand new Discourse.

Welcome message sent to new user is not showing images (broken image?).

What is it happening so?

(It seems I can’t upload image as I’m new user here)

Thanks.


(Jeff Atwood) #2

Viewing older welcome PMs this might be the case, but for a truly new user it will be correct.

Can you repro on try.discourse.org? Create an account there and see.


(Tenzan) #3

I’m seeing same thing on try.discourse.org as well, except the image that’s showing Life Instructions.

I don’t think something wrong with my browsers…

I’m using Mac OS X Yoshemite.
Chrome and Firefox.


(Jeff Atwood) #4

Oh right try has a bad old copy pasted version of that. Sorry, bad example, that is an override specific to try.


(Jeff Atwood) #5

There is no bug since your account is new here and your new user welcome PM looks 100% correct

https://meta.discourse.org/t/welcome-to-discourse-meta/29913?source_topic_id=29915

This link will only work for staff and the OP as it is a link to a PM…

Maybe update your Discourse to latest code?


(Tenzan) #6

My dashboard says 1.4.0.beta2 and it’s the latest…


(Tenzan) #7

I was following this guide for installation discourse/INSTALL-cloud.md at master · discourse/discourse · GitHub

And it installed the beta version. Maybe because of that I’m having broken images.

I wonder why it didn’t install the stable version :smile:


(Jeff Atwood) #8

This is the beta version running here. You signed up on the beta version. This is your new user welcome PM from the beta version.

https://meta.discourse.org/t/welcome-to-discourse-meta/29913?source_topic_id=29915

Can you repro it being broken there? Does it look broken to you?


(Tenzan) #9

Hi @codinghorror !

Yes, the welcome message for a new user looks broken to me.

Steps to reproduce:

  1. Install Discourse as shown in discourse/INSTALL-cloud.md at master · discourse/discourse · GitHub
  2. Register a new use

Result:
When user finishes registration it receives a welcome message with broken images (or links?).

I’m under impression, the links for images look broken, because there’s no any message on the server.

Why here discourse/INSTALL-cloud.md at master · discourse/discourse · GitHub it was not mentioned that it will install a beta version?

What should I do to install the stable one?

Thanks.


(Jeff Atwood) #10

I can’t reproduce this.

Here’s a screenshot of a user’s PM welcome that signed up here. His name is @tenzan

Per view source, the current version is <meta name="generator" content="Discourse 1.4.0.beta2 - https://github.com/discourse/discourse version 74e825fff2cb2d2978977da50ebea0a8cdb86b94">

Here’s me signing up on another Digital Ocean install I just did for a customer, 1.4 beta 2 as well:

As you can see images are all there.


(Tenzan) #11

@codinghorror

Can you please PM to me your email address to where I can send you a registration invitation from my Discourse install?

So, you’ll be able to see how it looks.

Thanks,


(Tenzan) #12

Another thing I forgot to mention: I was setting up a default locale to be ru - can this be the root cause?


(Jeff Atwood) #13

Yes, this is because the image names changed in English and the translated versions either need to have their own images (localized with the right character set), or change to use the English image names.


(Tenzan) #14

I see :smile:

BTW, where to report typos in Russian translation (I noticed at least one) ?


(Tenzan) #15

IMHO, it’d be nice to leave the default images when a non-english locale is default and there’s no translated images.
This way it looks better than broken images links :smile:


(Jeff Atwood) #16

The new URL paths need to be “translated” to your language.


(Tenzan) #17

I assume this will be done by when stable version comes…


(Mik01aj) #18

I just tried registering a new user on my installation. I use ru as well. The message looks like this:

In the source (at /admin/customize/site_text/usage_tips), the image is specified as:

<img src="/images/welcome/progress-bar.png" width="143" height="39">

I can fix this setting myself, but then, what would be new, correct path?


I think you can just tell @meglio :slight_smile:


(Tenzan) #19

I have set english locale back, so from my memory, the russian translation for the word “Error Logs” in Admin panel, it was translated as “Журнаш ошибок”.

The last letter of Журнаш must be л instead of ш --> Журнал.


(Tenzan) #20

As you see, in your screenshot, you’re still having a broken image in the bottom.