I was getting a bit confused about this topic … so this is the current and final solution yes @joffreyjaffeux ?
Yes this is it. It was a bit confusing for multiple reasons:
- I made it possible to invite from mobile which wasn’t possible before
- some buttons were merged (topic footer buttons)
- apple decided to enable native sharing about at this time, and my method to check lack of native support was not great and lead to an action showing both native and modal on apple devices
This is not ideal but I dont see a way to mix native and non native UI in one action.
I think it is fine if:
-
post level share opens the OS-native share, where available
-
post level date (upper right) opens the Discourse share, which includes invite
-
topic level share opens Discourse share, which includes invite
Thats the situation. Only clicking on the date in a post will show the sharing card.
this one does not include invite, but “new topic” which is another kind of action we have.
Kind of wonder if topic footer buttons shouldn’t be named invite, with invite being first panel, given you have an explicit share action under each post.
Ehhhh I dunno, one of the reason we moved that functionality is that it was so rarely used. Elevating it back to first billing on the button doesn’t seem like a wise choice to me; sharing is (far) more common than inviting.
Yes agreed, but this way we have both easily accessible without having two buttons. Fine leaving as it is, will see if people ask “where is the invite button” often. probably not.
This topic was automatically closed after 24 hours. New replies are no longer allowed.