When deleting a user fails, the alert dialog did not pop up properly

pangbo · March 10, 2023, 1:14pm

In my recent test, I found that when the user fails to delete himself in the “Preferences”, the corresponding error dialog box does not pop up normally.

After reading the source code, I suspect that this line of code is missing a call to next.

github.com

discourse/discourse/blob/3e8d3494651c50751ec248506a9e4a13137e5c6b/app/assets/javascripts/discourse/app/controllers/preferences/account.js#L219


      
                        this.dialog.alert({
                          message: I18n.t("user.deleted_yourself"),
                          didConfirm: () =>
                            DiscourseURL.redirectAbsolute(getURL("/")),
                          didCancel: () =>
                            DiscourseURL.redirectAbsolute(getURL("/")),
                        });
                      });
                    },
                    () => {
                      this.dialog.alert(I18n.t("user.delete_yourself_not_allowed"));
                      this.set("deleting", false);
                    }
                  );
                },
              },
              {
                label: I18n.t("composer.cancel"),
              },
            ],
          });

I modified this line in development environment, like this
next(() => this.dialog.alert(I18n.t("user.delete_yourself_not_allowed")));
then I found that the dialog popped up normally.

I’m not very familiar with ember, so I don’t know if this modification is correct, but it seems that there must be a bug here

Topic		Replies	Views
Removal of ember-addons/ember-computed-decorators Dev	12	1578	February 20, 2020
Alert used to Notify AutoComplete Support? Dev	5	1156	February 23, 2016
Could not find module ember addons Support	4	793	February 10, 2022
Error when trying to save duplicate email Bug	3	1019	January 23, 2016
New installs will default to Ember CLI builds in Production Announcements ember	36	3355	June 17, 2022

When deleting a user fails, the alert dialog did not pop up properly

Related topics