Work on better emoji support

Should be fixed by: https://github.com/discourse/discourse/pull/4941/commits/7c68949e040a8e3d70282726a79fc81c8a23cc48

Sadly, it won’t fix the thumbsup/thumbsdown autocomplete ordering as d is still before u, and I see only “hacky” ways to fix this, so probably not worth it.

Shouldn’t we order by the $UNICODE_ORDER value? ie the order here.

3 Likes

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/pretty-text/emoji.js.es6#L85

We display a list of emojis in autocomplete based on text search. IMO if the results are not alphabetically sorted it will be weird and not what people expect most of the times.

3 Likes

:thinking: I was thinking about you typing “thumbs” and get all matching emoji, sorted by the Unicode order, aka this file order: http://www.unicode.org/emoji/charts/emoji-ordering.txt

1 Like

Yes I understand, this is basically doing two sorts, and ending up with a list not alphabetically sorted. I think it’s overkill and misleading in most cases. Although I agree it would fix the thumbsup/down issue.

1 Like

I’m not sure that users have any expectation that autocomplete is in alphabetical order - ideally you want the “most likely thing” to be at the top.

Google search autocomplete is one example where it certainly isn’t in alphabetical order.

7 Likes

The emoji tone picker has been merged and is now available on meta, there’s an alignment issue on iOS safari that will be fixed tomorrow.

11 Likes

Looks good!

:kissing_smiling_eyes: :kissing:

Hmm selecting skin tone from the picker doesn’t seem to do anything?

Skin tone is only supported on some emojis :older_man:t4:

Weird is there a list? It is very confusing the way it is now.

In the iOS picker you only get that ui element when an appropriate emoji is selected, that is how we should do it too @joffreyjaffeux

Trouble is that once you select an emoji the whole modal vanishes, I would rather just shelf all refinements here till we build the non-modal version of the emoji picker. The Twitter Emoji is the gold standard imo and it keeps these boxes around all the time.

Note, in iOS mobile you only get the selection on long press, which we can not really simulate.

3 Likes

Oh aha when you select a skin tone, all the ones that can change color, do change color:

That’s just not obvious when you are on the first page, as nothing happens to be skin-tone-changeable in that early group.

1 Like

true, luckily the new picker will fit a lot more icons so there is a strong chance that they will appear before the fold.

3 Likes

I can also slightly change order to make sure it happens.

Just wanted to say :face_with_raised_eyebrow: :exploding_head: I love the latest emoji update :love_you_gesture:

10 Likes