Wrong statistics


(Jean-Michel) #1

Hello

Sometimes wrong statistics :
Only few dates displayed, grouped stats (see picture) ?

Sometimes good statistics :
Each date displayed, good stats.

Discourse : 2.1.0.beta4
Of course form re-submit after date choice.


(Jeff Atwood) #3

Sorry I am unclear, what is wrong about this? It looks fine to me?


(Mittineague) #4

I see only 6 markers for the 7 week range.

This suggests that there were no user visits for the days that don’t have markers. @Jean-Michel25 do you know for a fact there were user visits for those other days? Is there any reason that you can think of that might explain why the counts are “rolled up” into weekly instead of daily? Why nothing is displayed for Aug 8 to Aug 21?


(Joffrey Jaffeux) #6

Before I dig too much, can you try to update to latest please ?


(Jean-Michel) #7

I check the stats every day.
Always over 100 users / day.

Sometimes I’ve 1 marker / day, sometimes only a few in the range…

This morning I try to give you printscreen of the 2 ways


(Jean-Michel) #8

I can reproduce easyly the problem :

I try all the dates for the 1st param, from 2018-07-01 and up day by day.
Each time, of course, I update (twice or more).
The markers are ok for 2018-07-14 and plus (15, 16…).
The markers are KO for 2018-07-13 and less (12, 11…)

And the “table” display is according to graph.


(Joffrey Jaffeux) #9

Ok I see what’s going on :+1: will push a fix today thx


(Joffrey Jaffeux) #10

Ok this is actually not a bug on dates, but our collapseWeekly() code will do this when there are more than 40 data points to make it easier to read.

@sam I feel like we should change it, to make sure it shows first and last date of the range, what do you think? Otherwise it can be disturbing.


(Jean-Michel) #11

OK thanks for this

It would be is usefull having somewhere day average.
Maybe a hover popup on markers ?


#14

Whilst we’re looking at the dashboard … this is what I have this morning after upgrading last night (to v2.1.0.beta5 +7). Is this just a case of Sidekiq not having caught up? (but I see some Dashboard jobs have run).


(Joffrey Jaffeux) #15

What are you talking of exactly? Something looks totally wrong?


#16

Yesterday = Last 7 = Last 30

Interestingly, even before the upgrade, Last 7 equalled last 30 and there were odd hover stats saying "0 for previous 30 days "

Hope that helps.

Many thanks for looking into it.

PPS It doesn’t look like I’ve lost any history because historical graphs are fine. Just the dashboard aggregation seems odd.


(Joffrey Jaffeux) #17

Indeed, looks weird, will look.


(Mittineague) #18

I just checked the SitePoint dashboard. It displays the same Y = 7 = 30 oddness.


(Joffrey Jaffeux) #19

Ok this should be fixed by:

I also added a test for this, time based tests are kind of complicated on the client side ATM (while being very easy on server side). I gave it a shot to ensure we are not regressing on this again in the future, this test might have erratic behaviour. I will track it in the next days and the next blood moon as it’s usually when time based tests fail…

Thanks for reporting this.

:information_source: only the counters bug is fixed. The other question about collapsing chart is still being discussed internaly.


#20

That’s fixed it thanks.

Unfortunately it still tells me “Was 0 in the previous 30 day period” on the hover tooltip for Last 30.

But a big bug fixed, thank you!


(Joffrey Jaffeux) #21

Yes I’m aware of this. It’s not a bug, it’s simply that “prev30days” is not implemented for this report. It will work for some reports if you look closely.

However, I feel like I should just better handle this so I pushed this commit:

If there’s no prev30days data in the report, it won’t show the trending icons anymore. This commit has also an example of how to add this to a report. #pr-welcome if someone wants to add it to other reports.


(Joffrey Jaffeux) #22