A user reported an issue where they couldn’t see avatars of people who liked posts. kokmok investigated and found that the post_action_users endpoint response had an unknown property set to true. After reviewing the source code, kokmok discovered that not only muted or ignored users, but also those who are disallowed from sending private messages (disallowed_pms_from), are hidden.
kokmok noted that this behavior is unexpected, as users who disallow private messages from others will not see any avatars in the likers list at the bottom of posts. simon agreed, pointing out that this behavior is inconsistent, especially when compared to the Discourse Reactions plugin, which allows users to see avatars of users who have liked their posts even if they are not allowed to send private messages. kokmok added that this issue affects not only likes on the user’s posts but all likes on all posts.
In fact all objects in the endpoint post_action_users response have unknown property set to true (see screenshot).
I’ve incarnated him and can’t find something suspicious in his profile settings. I don’t know if it’s a bug or a side effect of one of his setting.
Problem solved, reading the source code.
Not only muted or ignored users are hidden, but also disallowed_pms_from ones.
My user had both DM setting boxes checked and no user selected in the white list.
By the way, if a user disallow DM from other users he will not see any avatar in the likers list at the bottom of the posts ? It’s a quite unexpected behavior.
It doesn’t seem like the correct behavior to me.
Oddly, when I first tried to reproduce the issue, I had the Discourse Reactions plugin enabled. With the Reactions plugin enabled, users can see the avatars of users who have liked their posts even if the user is not allowed to send them messages. That seems like the correct behavior to me.
With the Reactions plugin disabled, users cannot see the avatar of users who have liked their posts if the user who liked the post is not allowed to send them messages.
I’ll re-categorize this topic to the Contribute > UX category to see if it’s something the Discourse team want to look into.
Also it’s not only the likes on their posts, but all the likes on all the posts.
