Groot probleem met themacomponenten na update

Fout
1

I just updated to this : Commits · discourse/discourse · GitHub 2f398db9b66f19220b5a7f56721a68f41dcdeeec

Two different theme components now completely break my site. They are the “Modern Category + Group Boxes” from Air Theme and Avatar Size and Shape

They render the site unusable (looping?). Happens on both Firefox and Chrome (desktop)

image
image855×987 65.6 KB

I have tried them with no plugins and in isolation on different themes (ie safe mode with no plugins and on an isolated theme), so I don’t think it’s specific to my instance.

Console reports lines like this:

Uncaught TypeError: Cannot read properties of null (reading ‘syscall’)

Uncaught (in promise) TypeError: Invalid value used as weak map key

message-bus.js:118 MESSAGE BUS FAIL: callback /latest caused exception TypeError: Cannot read properties of null (reading ‘syscall’)

As a temporary solution, I have forced my users onto a generic theme until it’s figured out. Please let me know if you can replicate this error.

4 likes
2

Sorry, ik kan het tot nu toe niet reproduceren

2 likes
3

I’m experiencing the same issue on my site. For example, when I log out, the page turns completely white with the same error. Some users also reported that they can’t log in because the page is just blank. It seems to happen randomly.

The main problem is that there’s no clear error message to indicate what’s causing it. I tried to track it down by checking my theme components. I’ve already updated most of them to gjs, but here’s the interesting part: when I deactivate and then reactivate a specific component, the site starts working again without errors. I still don’t know what’s causing this issue though… It seems that the problem only occurs on pages where a (custom) theme component is present. So at least this gives me a clue that the issue must be coming from one of the components.

1 like
4

This might help track it down:

Check the helpers!

5

kun je een pagina/site delen waar het gebeurt @Don @piffy?

1 like
6

Here is a simple theme I set up that only has the avatar component: Elite Fourum - E4 - efour

https://www.elitefourum.com/latest?safe_mode=no_plugins&preview_theme_id=39

image
image732×754 57.8 KB

I can repo the issue at this link on firefox and chrome (desktop)

Modern Category + Group Boxes : Elite Fourum - E4 - efour

https://www.elitefourum.com/?safe_mode=no_plugins&preview_theme_id=58

image
image685×884 55 KB

this one seems harder to repo. It causes issues when I’m logged into my admin account (chrome and firefox) but not when I try on a dummy account. The bugs seem similar though between both theme component so maybe fixing one will solve the other.

Hope it helps!

1 like
7

the closest thing I could get to an iterpretable error message is

client-error-handler.js:125 [THEME 39 ‘Test’] Error: Could not find module admin/components/color-input imported from (require)

image
image1000×306 52.1 KB

the customize-edit-category-general.js is coming from the Air Theme:

in core:

8

This looks like the same issue: Forum navbar is repeating

1 like
9

This will fix the color-input error from the air theme. But this issue is not new, so I think it’s unlikely to be the cause of these rendering errors

2 likes
10

@piffy kun je alsjeblieft proberen te updaten naar de nieuwste tests-passed, voor het geval die color-input fix helpt.

Als de dingen na een rebuild nog steeds kapot zijn, probeer dan dit:

./launcher enter app
rails c
Discourse.clear_all_theme_cache!

Hetzelfde geldt voor jou @don, als je tijd hebt.

Als dat het probleem oplost, suggereert dit dat we een probleem hebben met de thema-cache-invalidatie die had moeten plaatsvinden toen we vorige week de Ember-versie hebben verhoogd.

2 likes
11

Thanks David, it seems this do the trick for me.

1 like
12

Bevestigt ook dat de update niet heeft geholpen, maar dat het opnieuw instellen van de thema-cache wel werkte.

2 likes
13

Ok, geweldig, bedankt voor de bevestiging! We zullen proberen dit probleem op te lossen in het thema-caching systeem, zodat handmatige actie niet nodig is.

Maar ondertussen, voor iedereen die deze problemen tegenkomt:

Uncaught TypeError: Cannot read properties of null (reading ‘syscall’)

Uncaught (in promise) TypeError: Invalid value used as weak map key

Neem deze stappen in de console:

./launcher enter app
rails c
Discourse.clear_all_theme_cache!
4 likes
14

@piffy @Don draaien jullie beiden een standaard installatie met één container?

1 like
15

Yes, I’m on a single-container standard install.

1 like
16

I’m running Ubuntu 20.04.6 LTS (I see it’s no longer officially supported) on DigitalOcean, single container.

Notable deviations from standard install:

1 like
17

Nog een vraag. Toen het voor het eerst misging, was je toen een UI-update aan het uitvoeren of een CLI-rebuild?

18

CLI

meer woorden toevoegen om de limiet van 20 tekens per bericht te omzeilen

1 like
19

Ja, ik ook. Ik heb eerst de UI-update gedaan.

1 like
20

I haven’t been able to reproduce the problem, but I did find one possible problem which is specific to the way UI-based upgrades work. This should take care of it:

It also forces a recompilation, so sites that have already been affected by this bug will be sorted after their next update.

5 likes