设置主题计时器可能导致灾难性故障

zogstrip · 2026年三月25日 15:09

抱歉，@hellekin，那个功能中确实隐藏了一些错误

github.com/discourse/discourse

FIX: Prevent topic timer crashes when publishing to category (#38872)

main ← fix/topic-timer-publish-to-category

opened 03:08PM - 25 Mar 26 UTC

ZogStriP

+78 -10

Setting a "Schedule Publishing" topic timer without selecting a destination cate…gory could silently save the timer with the uncategorized category as the target and subsequently crash the topic page. The root cause was `set_or_create_timer` defaulting `category_id` to `SiteSetting.uncategorized_category_id` when not provided. The controller only passed `category_id` when present in params, so omitting it resulted in a valid (but wrong) timer being persisted. On the client side, if the saved category wasn't in the browser's category cache, `Category.findById()` returned undefined and the subsequent `.get("slug")` call threw a TypeError during rendering, which could destabilize the page. This commit: - Changes the default `category_id` in `set_or_create_timer` from `SiteSetting.uncategorized_category_id` to `nil`, so the existing model validation (`validates :category_id, presence: true, if: :publishing_to_category?`) rejects the record - Requires `category_id` in the controller when setting (not removing) a `publish_to_category` timer - Adds client-side validation in the modal before sending the request - Fixes a typo (`this.topicTime` → `this.topicTimer`) that caused stale timer state after removing a timer from the modal - Adds a null guard on `Category.findById()` in `TopicTimerInfo` so a missing category degrades gracefully instead of crashing https://meta.discourse.org/t/398284

話題		回覆	觀看
Topic timer causing error? Support tag-banners	1	289	2024年四月1日
Scheduled publishing renders topic unusable Bug	3	581	2022年四月6日
Draft topic with scheduled publication misses destination category UX shared-drafts	3	291	2025年八月4日
Scheduling topics for future publication Site Management how-to , topic-timers	0	19305	2017年四月10日
Issue with Publish to Category topic timer Support topic-timers	6	678	2021年二月20日

设置主题计时器可能导致灾难性故障

相關主題