Email notifications don't get sent on category change for mailing list mode users

[wesochuck (Wes Osborn)]

Repo steps:

1. Set a user account to mailing list mode.
2. Post a topic in a secure category that the user doesn’t have access to (e.g. Staff)
3. Change the category to of the topic to a public category that the user does have access to
4. The mailing list mode user will never get an email notification of the topic

This affects us on a regular basis because we typically jointly compose topics in a DRAFT mode in our staff category before pushing them out to our users. We also have several power users in our forum that use mailing list mode to make sure they “don’t miss anything” and of course, in this case, they end up missing some of our most public announcements.

More background:

Continuing the discussion from Mailing list mode user not getting emails and not appearing in skipped_email_logs:

@wesochuck

I think we’ve narrowed this down to when there is a topic that was started in a “secured” category (like Staff) and then moved to a public one. So, we’ll draft something and then put it in a public category and those are the alerts these folks are missing.

[wesochuck (Wes Osborn)]

Just updating that I’ve confirmed this is still an issue in version: 3.3.0.beta2

[RGJ (Richard - Communiteq)]

We have found the issue. This case is simply never accounted for.

A solution is to call :notify_mailing_list_subscribers from the NotifyCategoryChange job. I have just verified that this is working.

Team, would you accept a PR for this or is this plugin territory?

[lindsey (Lindsey Fogle)]

@RGJ

Team, would you accept a PR for this or is this plugin territory?

Sure, we’d be happy to review a PR for this update. Thanks!

[jyuvaraj03 (Yuvaraj J)]

I have raised a PR for this fix!

[zogstrip (Régis Hanol)]

Thanks @RGJ / @jyuvaraj03 - I’ve merged the PR