ganncamp
(G Ann Campbell)
May 11, 2022, 2:18pm
1
We’re starting to use assignment heavily
When I assign, I click in the dropdown and start typing.
My hands are on the keyboard at this point, so it’s natural to arrow down to the correct choice & hit ‘Enter’ to select it. … At which point the dialog closes.
Since the ‘Note’ field is under the assignee field, my expectation is that I would have a chance to add a note after I’ve picked the assignee. But that’s not how it works in practice.
3 Likes
Jagster
(Jakke Lehtonen)
May 11, 2022, 3:24pm
2
Is there possibility to add a note
This is what I get when using iPad:
sam
(Sam Saffron)
May 12, 2022, 4:35am
4
Oh I have a repro @nat , this looks like an edge case we missed.
The enter should not assign if notes are turned on. The click on avatar though should
@Jagster to get notes you need to be on latest, very recent feature.
4 Likes
Jagster
(Jakke Lehtonen)
May 12, 2022, 6:18am
6
Yup. Now it is there. Something what I have needed — thanks all of you.
4 Likes
nat
(Natalie T)
May 12, 2022, 3:19pm
7
Here’s the PR:
discourse:main
← discourse:only-assign-when-suggestion-click
opened 09:18AM - 12 May 22 UTC
<img width="436" alt="Screenshot 2022-05-12 at 5 17 08 PM" src="https://user-ima… ges.githubusercontent.com/1555215/168037041-40ff260e-c7ad-4edc-a2a1-689c2efeabfe.png">
There’s also something else in the works to show notes in the moderator posts (they currently only show up in the tooltip on the topic header):
discourse:main
← discourse:show-note-in-moderator-post
opened 02:15PM - 12 May 22 UTC
Shows the assignment note in moderator post.
Note there were no migrations to… retroactively add the notes into small action posts
- A small action post generated from assignment has no relation to its topic/post
- its `PostCustomField`s used in assign are used elsewhere as well (e.g. `action_code_who` etc)
- Vice versa, an assignment does not have relationship to its generated small action post
Each note modification also adds a moderator post, rather than modify the previous post. If we wish to have that, it's possible too.
<img width="496" alt="Screenshot 2022-05-12 at 10 21 14 PM" src="https://user-images.githubusercontent.com/1555215/168097273-7a1af897-902d-470e-8836-f3d6af50005b.png">
2 Likes
ganncamp
(G Ann Campbell)
May 27, 2022, 2:45pm
9
I’d like to add to the original thread,
We’re starting to use assignment heavily
When I assign, I click in the dropdown and start typing.
My hands are on the keyboard at this point, so it’s natural to arrow down to the correct choice & hit ‘Enter’ to select it. … At which point the dialog closes.
Since the ‘Note’ field is under the assignee field, my expectation is that I would have a chance to add a note after I’ve picked the assignee. But that’s not how it works in practice.
but that got closed.
Not only am I still seeing this, but I just tired adding a comment before I made the assignment and my comment seems to have disappeared into the ether.
Do I need to do something on our hosted site to get the fix that was created on the 12th?
1 Like
I’ve scooted it over, and reopened the topic.
As for the question itself, I shall have a look and see if you still need the fix or if this is something new.
dax
(Daniela)
May 27, 2022, 3:48pm
14
Hey Ann,
Try now after an hard refresh of the site. You are on the latest version and you have both of Nat’s fixes.
3 Likes
ganncamp
(G Ann Campbell)
May 27, 2022, 4:41pm
15
To be clear @dax , you mean a hard browser refresh? Because I just restarted yesterday…
But I’ve done the refresh. So far so good…
I’ll need to come back to this next week (after Memorial Day) to be sure tho. Can we leave the topic open that long, pls?
Edit: Okay… I got confused. I just realized that this^ response itsn’t relevant to this thread.
Yes! This is working. Thanks!
3 Likes
dax
(Daniela)
May 27, 2022, 6:12pm
16
Sorry, yes, I just meant a hard browser refresh as I had just finished updating your site
2 Likes