Blank page after upgrade and javascript error

[hellekin]

Hello. Latest build (commit 0adaa7c) brings it back after some years

It comes right after the discourse-presence plugin is integrated and enabled by default. Should I remove it from the list? I have renamed it so it looks like

I thought it failed because I changed the container configuration without running ./launcher rebuild app but then I ran it and:

I, [2017-09-07T12:41:47.226058 #14]  INFO -- : > cd /var/www/discourse/plugins && git clone https://github.com/discourse/discourse-presence.git
fatal: destination path 'discourse-presence' already exists and is not an empty directory.
I, [2017-09-07T12:41:47.232919 #14]  INFO -- :


FAILED
--------------------
Pups::ExecError: cd /var/www/discourse/plugins && git clone https://github.com/discourse/discourse-presence.git failed with return #<Process::Status: pid 159 exit 128>
Location of failure: /pups/lib/pups/exec_command.rb:108:in `spawn'
exec failed with the params {"cd"=>"$home/plugins", "cmd"=>["mkdir -p plugins", "git clone https://github.com/discourse/docker_manager.git", "git clone https://github.com/discourse/discourse-spoiler-alert.git", "git clone https://github.com/discourse/discourse-voting.git", "git clone https://github.com/discourse/discourse-solved.git", "git clone https://github.com/discourse/discourse-assign.git", "git clone https://github.com/discourse/discourse-presence.git", "git clone https://github.com/lidel/discourse-openstreetmap.git"]}
6cdaf8b12114762b0bc1f96f3f014e0ad5e356c24b49370812bd4513a147ce0f
** FAILED TO BOOTSTRAP ** please scroll up and look for earlier error messages, there may be more than one

On the server-side nothing’s wrong. The /logs/report_js_error contains only OK which gives a syntax error. See screenshot below.

[hellekin]

fatal: destination path 'discourse-presence' already exists and is not an empty directory.

So I guess I have to remove mention of this plugin…

[David_Taylor]

Should I remove it from the list?

Yes, discourse-presence is now part of core, so you need to remove the line from your app.yml file

[hellekin]

Indeed, while you replied I went:

cd /var/discourse
./launcher start web
./launcher enter web
cd plugins
mv discourse-presence/ discourse-presence-legacy
^D
./launcher rebuild web

The rebuild continued, but the error was still there. Having the legacy code in the way caused problem.

So I removed the line entirely as you suggested, and it’s rebuilding now…

[hellekin]

No luck… It looks like a bug…

The /logs/report_js_error contains only OK which gives a syntax error.

What is the purpose of this file? Does this syntax error come before or after another error?

[hellekin]

rebuild from master: works.

Still have an error though in the console:

[pfaffman]

You need to remove it from app.yml.

[David_Taylor]

Still have an error though in the console:

Is this the console on the /admin/upgrade page? If so you may have hit this issue:

Fatal JS error breaking /admin/upgrade page

Hello! I’ve set up a fresh Discourse instance (private), and it’s working great as usual, except that /admin/upgrade hits a JS error that prevents anything on the page from loading. This is on v1.9.0.beta8 +41. [12 AM] It looks to me like perhaps the loading order has changed. In poking around I found that some code related to this has recently changed, so perhaps these are relevant: Disable javascript for disabled plugins Do not load javascripts for disabled plugins by davidtaylorhq · Pu…

[hellekin]

Is this the console on the /admin/upgrade page?

No it’s the console on any page, running the master branch at PERF: Remove `Object#present?` check introduced in https://github.com… · discourse/discourse@58321d0 · GitHub (the one after your fix to that bug you mention.)

Commits · discourse/discourse · GitHub still mentions the build failing… I’m going to wait until test-passed includes your fix to revert to that branch.

[David_Taylor]

If the Discourse.markdown error is on every page then maybe it’s not the same issue. What plugins do you have installed?

[hellekin]

OK, thanks for your interest @David_Taylor, but I guess it’s a different topic. I resolved the blank page issue by switching to the master branch that includes your reverts. Now, on the master branch, there’s still this Markdown issue that doesn’t seem to affect much of the site use.

Since you asked, here’s my list of plugins:

hooks:
  after_code:
    - exec:
        cd: $home/plugins
        cmd:
          - mkdir -p plugins
          - git clone https://github.com/discourse/docker_manager.git
          - git clone https://github.com/discourse/discourse-spoiler-alert.git
          - git clone https://github.com/discourse/discourse-voting.git
          - git clone https://github.com/discourse/discourse-solved.git
          - git clone https://github.com/discourse/discourse-assign.git
          - git clone https://github.com/lidel/discourse-openstreetmap.git

I suppose the last one is the culprit since the others are official.

[Mittineague]

I suppose the last one is the culprit since the others are official.

That is a good supposition.

Latest commit ca8318b on Mar 14, 2015

Much has changed since then.

@lidel

[hellekin]

Today I switched back to tests-passed from master and all is working again. I suspect the patch @David_Taylor was mentioning in response #8 was causing the blank page. All izz well now.