Box shadow based row highlighting for keyboard navigation not working on Edge

Our j k based row highlighting in not working in Microsoft Edge.

image

This appears to be happening due to this problem:

@awesomerobot can you add this to your list? I don’t want to break Chrome/Firefox to fix Edge here, but it looks like we are doing something not exactly fully compliant here.

4 Likes

Turns out Edge doesn’t support box-shadows on tables that have border-collapse: collapse, I found an existing issue from 2015… so not expecting a fix anytime soon.

Fortunately, what does work is setting box-shadow to inset.

36%20PM

Unfortunately inset would overlap with avatars on topics (which aren’t tables and don’t have this problem anyway).

22%20PM

So the best option is to set the box-shadow to inset on tables and leave it outset on posts.

https://github.com/discourse/discourse/commit/331296e851e1726bf312eb16234226a56dbb0844

6 Likes