Can't click "All notifications" in the notifications bar of a user as a moderator

UX
1

Repro steps:

  1. You have to be a moderator, not an admin
  2. Go to someone’s user profile other than yours.
  3. Go to notifications
  4. Try to click all notifications
  5. It should be blocked.

3 Likes
2

Hi @Chaboi_3000 local repro confirmed. Thanks will :eyes:

3 Likes
4

Seems like this is expected behaviour per:

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/routes/user-notifications.js.es6#L20

Only admins can see all notifications from a specific user, and if we don’t have a model we redirect to responses https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/routes/user-notifications-index.js.es6#L8

4 Likes
5

@joffreyjaffeux, I think this “redirect” is quite confusing. I think it’s better off just removing the “all notifications” for a moderator.(Except for their own notifications of course)

2 Likes
6

Yes I don’t have strong feelings on this, just wanted to say it’s not a « bug ». I do think it’s fine as it is.

Want to hear from @codinghorror on this.

4 Likes
7

It is very minor so I don’t think we need to worry about it.

3 Likes
8

the activity tab be hidden with css, except for admin users.

Not “secure” but functional. It’s bondo in a dent. But works