Missing Mark all as Read for Notifications

Considering the Profile “landing” page is slated to become the Summary soon and this is somewhat edge case, probably not worth worrying about it much.

Typically, unless a Notifications link is specifically clicked I land on Profile Activity.

If I go to Profile (Activity) and click Notifications, there is a “Mark all as Read” button.

But if I go to User Card -> Avatar -> Profile (Activity) and click Notifications, the button is not there until I do a page reload.

6 Likes

On imgur they were saying it sometimes appears and sometimes does not – very likely a bug of some kind.

2 Likes

I thought @sam removed the Mark all as read button a while back…I can’t find that button at all here on Meta.

It’s here https://meta.discourse.org/my/notifications

Where?

:smiley:

1 Like

I could see it if I visited my notifications before visiting this topic. If I go back now it is gone…

It’s only visible when you have unread notifications.

https://github.com/discourse/discourse/blob/514c3976f05785f487d275af1e96c43533e7a478/app/assets/javascripts/discourse/controllers/user-notifications.js.es6#L8-L8

5 Likes

Vanishing buttons and disabled buttons seem to consistently cause confusion for no gain, we should probably change this

10 Likes

I support leaving it there for notifications since this has come up a few times already.

4 Likes

:bomb:

https://github.com/discourse/discourse/commit/8df69dba83d733038dfb2afe46146875538a5f3a

6 Likes