Can't mark a post as wiki anymore

I’m not seeing the green icon either. I’m on iOS at the moment. The pencil under the more icon is there, though.

1 Like

Ok this is fixed in

https://github.com/discourse/discourse/commit/32846aad2a511d631b3845cf1f72dea7ec689522

There were a couple of problems here:

  1. We were increasing the post’s version of the post client side without considering whether the post’s version was actually increased server side. That was causing all sort of weird rendering patterns because the post version is used to determine whether we show the edit icon.

  2. Marking a post as a wiki was bumping the post’s version which is wrong and results in a client side bug where the edit history window will contain a version without any changes.

9 Likes

This is fixed!

Thank you so much @tgxworld ! :slight_smile:

2 Likes

O dear. This is actually a feature we support and the post revision is meant to display the wiki icon if the post was made wiki. Will have to revert my change here and add tests for this case.

1 Like

Ok found the actual bug

https://github.com/discourse/discourse/commit/efc21366aebc0309febbd8fdc9ab9321b1db7b98

Reverting the previous change I made in

https://github.com/discourse/discourse/commit/781d83a46f2469c0e055c6c535822fa285870dce

3 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.