Can't remove a delete replies topic timer

bug
1

Trying to remove a “Delete Replies after days” topic timer from a topic fails:

image
image1271×119 10.6 KB

image
image846×473 32.1 KB

curl 'https://meta.discourse.org/t/151236/timer'  --data-raw 'time=&status_type=delete_replies'
{"errors":["param is missing or the value is empty: duration"]}
4 Likes
2

Also have this problem. Neither way works to remove it except to refresh page?

3

Should we assign this @eviltrout?

2 Likes
4

I think this should be fixed by:

https://github.com/discourse/discourse/pull/9800

I have asked a review from @vinothkannans as he worked on this. I feel like the spec here should be reworked, we currently randomly test on few types, but we should have a context for each type which would test create/update/delete.

What was happening here, is that we were requiring a duration for delete_replies type even when removing it, when we actually rely on the fact that duration is nil to remove the timer.

8 Likes
6

@Falco this is merged, let me know how it goes for you when you can test it.

3 Likes