Colour Scheme - can't select light theme


(Stephen) #1

With the new composer rolled into tests-passed I was just looking at colour schemes and found that selecting the light theme exhibits some strange behaviour:

Customize > Themes > New

By default the scheme appears as:

07

If I select the dark theme it appears as:

52

And if I select the light scheme again:

26

Prior to rebuilding I was seeing a similar problem with Customize > Colors, where I could create new schemes based on dark, but if I tried to clone the light scheme the +New button was active, but did nothing.


(Joffrey Jaffeux) #3

To be clear it’s technically not a select-kit issue, the theme causing the issue has null as value, and I think we should fix it instead of adding one more special case in select-kit. I will look what could be the most appropriate solution.


(Jeff Atwood) #4

Definitely, if this is an issue with a theme we ship, we should absolutely fix it!


(Stephen) #5

Ok, as the light theme isn’t directly editable can that be fixed?


(Joffrey Jaffeux) #6

let me see if I can push a quick fix


(Joffrey Jaffeux) #7

Should be fixed by:

I finally decided to fix it in select-kit directly, it was an issue to allow this at the beginning of select-kit, but it should work as long as we only have one item with null value in the content.

FWIW the null value comes from here: discourse/builder.rb at master · discourse/discourse · GitHub


(Joffrey Jaffeux) #8

This topic was automatically closed after 20 hours. New replies are no longer allowed.