Embed: dates are not localized


(probus) #1

Dates always show up in default (US) locale in embedded comments.


(Michael Downey) #2

Hmm. What do you mean “embedded comments”? Can you provide some detailed steps to reproduce this bug?


(probus) #3
  1. Switch Discourse locale to any other than English
  2. Embed Discourse comments on a website
  3. UI is localised but dates are not on the embedded (iframe) comments

(probus) #4

Any updates on this?


(probus) #5

Still in English, but we can now at least hide them with CSS.


(probus) #6

Happy anniversary! :birthday: :gift:


(Erick Guan) #7

Darkness leads me to this bug under the pale moonlight :new_moon:

But as a general tip, it would be definitely better if there is a link or screenshots. I can hardly understand what you are talking about if I haven’t translated the documentation :frowning:

Embed comments:

The problem is in embed/comments.html.erb:

then ember_helper.rb:

The fix can be either using the FreedomPatches::Rails4.distance_of_time_in_words, I18n.localize(dt, format: I18n.t("datetime_formats.formats.short_no_year")) or replace the link by a different translation string as the digest email.

; I don’t quite understand the current status of server time formats so I won’t fire PR here.