Embed: dates are not localized

probus · April 27, 2015, 2:42pm

Dates always show up in default (US) locale in embedded comments.

downey · April 27, 2015, 3:56pm

Hmm. What do you mean “embedded comments”? Can you provide some detailed steps to reproduce this bug?

probus · April 28, 2015, 5:14am

Switch Discourse locale to any other than English
Embed Discourse comments on a website
UI is localised but dates are not on the embedded (iframe) comments

probus · August 12, 2015, 11:42am

Any updates on this?

probus · December 2, 2015, 9:47am

Still in English, but we can now at least hide them with CSS.

probus · April 15, 2016, 1:45pm

Happy anniversary!

fantasticfears · April 15, 2016, 6:57pm

Darkness leads me to this bug under the pale moonlight

But as a general tip, it would be definitely better if there is a link or screenshots. I can hardly understand what you are talking about if I haven’t translated the documentation

Embed comments:

The problem is in embed/comments.html.erb:

github.com/discourse/discourse

app/views/embed/comments.html.erb

main


      
              <%= link_to(I18n.t('embed.start_discussion'), @topic_view.topic.url, class: 'button', target: '_blank') %>
            <% elsif @reply_count >= 10 %>
              <%= link_to(I18n.t('embed.continue'), @second_post_url, class: 'button', target: '_blank') %>
            <% end %>
            <span class='replies'><%= I18n.t('embed.replies', count: @reply_count) %></span>
          </header>
          
          <%- if @topic_view.posts.present? %>
            <%- @topic_view.posts.each do |post| %>
              <article class='post<%- if post.trashed? %> deleted<% end %>' id='post-<%= post.id.to_s %>'>
                <%= link_to embed_post_date(post.created_at), post.full_url, title: post.created_at.strftime("%B %e, %Y %l:%M%P"), class: 'post-date', target: "_blank" %>
                <%- if post.reply_to_post.present? && !post.cooked.index('aside') %>
                  <%= link_to I18n.t('embed.in_reply_to', username: post.reply_to_post.username), post.reply_to_post.full_url, 'data-link-to-post' => post.reply_to_post.id.to_s, :class => 'in-reply-to', target: "_blank" %>
                <%- end %>
          
                <div class='author'>
                  <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank"><img src='<%= post.user.small_avatar_url %>' alt=''></a>
                </div>
                <div class='cooked'>
                  <h3 class='username'>
                    <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank" class='<% if post.user.staff? %>staff<% end %><% if post.user.new_user? %>new-user<% end %>'><%= post.user.username %></a>

then ember_helper.rb:

github.com/discourse/discourse

app/helpers/embed_helper.rb

main


      
          # frozen_string_literal: true
          
          module EmbedHelper
            def embed_post_date(dt)
              current = Time.now
          
              if dt >= 1.day.ago
                distance_of_time_in_words(dt, current)
              else
                if dt.year == current.year
                  dt.strftime I18n.t("datetime_formats.formats.short_no_year")
                else
                  dt.strftime I18n.t("datetime_formats.formats.no_day")

The fix can be either using the FreedomPatches::Rails4.distance_of_time_in_words, I18n.localize(dt, format: I18n.t("datetime_formats.formats.short_no_year")) or replace the link by a different translation string as the digest email.

; I don’t quite understand the current status of server time formats so I won’t fire PR here.

weber-s · February 27, 2024, 3:34pm

Hello,

Just ran into the same issue.

I see the issue with the localization here because potentially no user is connected so it is complicated to estimate its locale… but could it be a setting? For discourse instance targeting only one language community, it would make sens!

JammyDodger · February 28, 2024, 8:23am

This one seems to have been around for quite awhile. I wonder if this pushes it more into the feature request territory rather than the bug bucket.

Lhc_fl · July 22, 2024, 10:44am

I have submitted a fix here:

github.com/discourse/discourse

UX: Use localized time format in embedded comments

main ← ux-localize-embed-posts

merged 10:42AM - 22 Jul 24 UTC

Lhcfl

+2 -2

Previously, the time format for embedded comments was hardcoded. This commit cha…nges it to the time format defined in I18n. Related meta topic: https://meta.discourse.org/t/embed-dates-are-not-localized/27997/ ## Screenshot: before: ![image](https://github.com/user-attachments/assets/b7e2d411-d7ca-4fd9-877a-fe6c3ca6ba55) after ![image](https://github.com/user-attachments/assets/52099768-6459-4108-864b-56befbe41c43)

Lhc_fl · July 24, 2024, 10:45am

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Insert Date Timezone is always UTC ; my Timezone is ignored Support	23	3644	December 21, 2019
Wrong time when using the date picker: bug? Bug	21	1657	December 6, 2020
Last version v2.3.0.beta10 +23 update. time of post not show Bug	9	1250	June 22, 2019
"Error Embedding" comments Support	16	2243	May 4, 2022
How can I troubleshoot Discourse comments embedding feature? Support	17	4783	June 26, 2015

Embed: dates are not localized

Related topics