When client.en has an empty string as a translation it shows up as missing

Bug
1

When editing a post, clicking “auto-close” to bring up the option, is missing the [en.composer.auto_close.all.units] translation.

6 Likes
2

For extra context:

Screen_Shot_2016-10-02_at_11_05_45_AM.png1436×462 41 KB

5 Likes
3

AHA, this is a new regression in our client translation system, for some reason if there is an empty string as the actual translation it shows up as missing.

I believe @eviltrout recently refactored this area, will try to find the culprit.

4 Likes
4

This should fix it:

https://github.com/discourse/discourse/commit/843c7a21c990f118722bdab1778ab91e16e7b835

8 Likes
5

Seems good, nice job! :+1:

1 Like