Error after update Docker Manager to ea174f7e

xkhalid · October 23, 2024, 6:18pm

Dear Gents,

I have a self-hosted Discourse instance, and when I attempted to update the Docker Manager to version ea174f7e, I encountered the following error:

Docker Manager: FAILED TO UPGRADE
#<ActiveRecord::StatementInvalid:"PG::UndefinedColumn: ERROR:  column users.password_hash does not exist\nLINE 1: ...ed_at\", \"users\".\"name\", \"users\".\"last_posted_at\", \"users\".\"p...\n                                                             ^\n">
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/rack-mini-profiler-3.3.1/lib/patches/db/pg.rb:69:in `exec_params'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/rack-mini-profiler-3.3.1/lib/patches/db/pg.rb:69:in `exec_params'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/postgresql_adapter.rb:894:in `block (2 levels) in exec_no_cache'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract_adapter.rb:1027:in `block in with_raw_connection'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/concurrency/null_lock.rb:9:in `synchronize'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract_adapter.rb:999:in `with_raw_connection'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/postgresql_adapter.rb:893:in `block in exec_no_cache'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/notifications/instrumenter.rb:58:in `instrument'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract_adapter.rb:1142:in `log'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/postgresql_adapter.rb:892:in `exec_no_cache'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/postgresql_adapter.rb:872:in `execute_and_clear'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/postgresql/database_statements.rb:64:in `internal_exec_query'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:630:in `select'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract/database_statements.rb:71:in `select_all'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/connection_adapters/abstract/query_cache.rb:115:in `select_all'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/querying.rb:62:in `_query_by_sql'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/querying.rb:51:in `find_by_sql'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/statement_cache.rb:150:in `execute'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/core.rb:431:in `cached_find_by'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activerecord-7.1.4/lib/active_record/core.rb:252:in `find'
/var/www/discourse/plugins/docker_manager/lib/docker_manager/upgrader.rb:261:in `log_version_upgrade'
/var/www/discourse/plugins/docker_manager/lib/docker_manager/upgrader.rb:136:in `upgrade'
/var/www/discourse/plugins/docker_manager/scripts/docker_manager_upgrade.rb:19:in `block in <main>'
/var/www/discourse/plugins/docker_manager/scripts/docker_manager_upgrade.rb:6:in `fork'
/var/www/discourse/plugins/docker_manager/scripts/docker_manager_upgrade.rb:6:in `<main>'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/commands/runner/runner_command.rb:41:in `load'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/commands/runner/runner_command.rb:41:in `block in perform'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/activesupport-7.1.4/lib/active_support/execution_wrapper.rb:92:in `wrap'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/commands/runner/runner_command.rb:40:in `perform'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/thor-1.3.2/lib/thor/command.rb:28:in `run'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/thor-1.3.2/lib/thor/invocation.rb:127:in `invoke_command'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/command/base.rb:178:in `invoke_command'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/thor-1.3.2/lib/thor.rb:538:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/command/base.rb:73:in `perform'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/command.rb:71:in `block in invoke'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/command.rb:149:in `with_argv'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/command.rb:69:in `invoke'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/railties-7.1.4/lib/rails/commands.rb:18:in `<main>'
/usr/local/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
/usr/local/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
/var/www/discourse/vendor/bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
bin/rails:18:in `<main>'

However, on the update page, it looks like everything is fine:

So, is there anything else I need to do?

Thanks !

ajtowns · October 25, 2024, 6:21am

I got the same error with the update progress bar aborted maybe 90%, 95% of the way through. Everything was reported as up to date afterwards, and then later updating Discourse to a new commit seemed to work fine.

otseng · October 26, 2024, 3:21pm

I had the same error. But after running the update again, it seemed to have upgraded correctly.

xkhalid · October 26, 2024, 8:55pm

CC: @sam @ella

Any help or suggestions regarding the error after updating Docker Manager? Everything is working fine for me now, but I’m worried that the next update might cause something to go wrong.

ella · October 28, 2024, 4:43pm

Thanks for reporting! We’re taking a look.

david · October 28, 2024, 5:03pm

The error is happening while docker_manager attempts to record the upgrade in the staff-action-log. This PR should get things sorted:

github.com/discourse/docker_manager

FIX: Minimize database access following `db:migrate`

discourse:main ← discourse:db-access

opened 04:57PM - 28 Oct 24 UTC

davidtaylorhq

+3 -1

The upgrade process was triggering the database migrations, and then calling `Us…er.find()`. This is problematic because the `users` table may have been changed by the migrations, and accessing it with the 'old code' will raise an exception. This commit tweaks the Upgrader so that it loads the user object into memory **before** running database migrations.

xkhalid · October 29, 2024, 7:35pm

Thank you @david

Topic		Replies	Views
Blank upgrade page after updating docker manager to 2.0.0.beta10 Bug	16	945	May 19, 2018
Beta upgrade failed: 3.1.0.beta8+248 > 3.2.0.beta1+15 Bug docker-manager	4	373	September 14, 2023
Failed upgrade from 2.9.0.beta14 to 3.1.0.beta Installation	11	1029	February 24, 2023
Sorry, there was an error upgrading Discourse. But then Discourse shows the module is up to date Support	2	546	November 29, 2020
Installing discourse for development is failing Installation docker , dev-install	3	769	April 10, 2023

Error after update Docker Manager to ea174f7e

Related topics