Issue adding tags

has happened a few times…

82a685f3b337740bc54de47646108a2f8cb09f46

trying to add a 3-character tag and i can’t seem to do it. the “create new tag” doesn’t always show up.

079873c4f1a043e584769473b775949e523e3203

That’s odd. Any consistency to when you can’t create a 3 letter tag? It works here on Meta when I try…

1 Like

i’ve had this issue a few times. ill give it another go… and see if it happens again in a way that reproducible.

A thought, which I don’t think I can test here on Meta, we don’t have enough similarly spelled tags - does it occur every time there are 5 existing tags that match the 3 letters?

1 Like

I’m pushing updates to this component next week, might improve this.

4 Likes

tried a few more times… had another issue.

50%20PM

couldn’t seem to add a new tag… women… the problem is that this tag already exists:

so, i published the post and then went back to edit the tag and add it post-publish… but then it showed me this strange view:

32%20PM

now it says i could create a new one even though it found it.

strange.

Yes I know about the last one, it’s kind of an edge case. And a little bit annoying cause the list of existing tags is async so I’ m not sure what kind of UI I should do here. As I don’t want to remove the field as you are typing if the list shows an existing tag.

For the first one I will check.

1 Like

Will be fixed by:

https://github.com/discourse/discourse/commit/410b90dde0d2a6382cc1425dd644147d2b55e420

Thanks

3 Likes

cool. had it happen again:

04%20AM

couldn’t create “gamengine”… but, i deleted it and typed in “gameengine” (two e’s) and then i could create.

and again.

49%20AM

I just pushed two fixes:

https://github.com/discourse/discourse/commit/9b680fc45c6540b65dcab6b4801b8e2322309c2a

https://github.com/discourse/discourse/commit/ba2f01c0bd7253dd8f1970c01e0876634803fe61

This should for sure fix this one:

49%20AM

Concerning the other issue, I would appreciate a more detailed reproduction.

6 Likes

kk. will continue to test post-update.

06%20AM

tried multiple times. showed “create” but disappeared when i got beyond “community” in the tag “ethereumcommunityfund”.

What’s your max tag length site setting? I bet “ethereumcommunityfund” is too long

2 Likes

38%20PM32%20PM

a few more issues.

max tag length is 20.

There was still a case where it could happen indeed:

https://github.com/discourse/discourse/commit/5e323139aeefa445aa5b46ac55d57ffb883a95b3

6 Likes

This topic was automatically closed after 2 days. New replies are no longer allowed.