Jump to post is inaccurate in big threads


(Erlend Sogge Heggen) #1

It appears when a thread contains a large amount of posts (I haven’t narrowed it down to an exact amount yet) the “post jump” feature has a tendency to increment the desired post number by one.

Also note that there’s no blue highlight animation when additional posts have to be loaded first.


#2

Slightly different behaviour but probably related to the same underlying cause: Following this link in Chrome at 1920x1080 maximised decrements the url by one position as the page loads, and the topic progress bar reads one further position less. (97, 96 and 95 respectively.)


(Jeff Atwood) #3

Depends if there are embedded remote linked images, I reckon.

Uploaded images should know dimensions; check upstream and see if any hotlinked remote images are there. Sometimes they’re too big to be converted to local images? Just a guess.

edit: hmm, checking when jumping to #50 and #60 from #1 you might be right. I don’t see any obvious hotlinked images that might be gunking up the works. Worth a look Monday @eviltrout to see if we regressed here.


(Robin Ward) #4

Jump to posts wasn’t respecting the gaps (hidden). I’ve fixed it and it seems to work well now:

https://github.com/discourse/discourse/commit/1e6dea46ddd12c96a467593d4237b4562876794f


(Erlend Sogge Heggen) #5

Cheers. One thing I’m still missing though is the blue highlight to help guide my eye. It’s very helpful when you land amongst several smaller posts, and it would also be the consistent thing to do.


(Jeff Atwood) #6

Hmm is jump to post not doing a fade? Can you confirm @eviltrout?


(Robin Ward) #7

I confirmed it wasn’t working when using the progress widget. It’s fixed in master (along with a big refactor to clean it up a lot)

https://github.com/discourse/discourse/commit/78d5d22776cd173bcbd9d5f62ebc1a87fd3a1e23


(Kane York) #8

This topic was automatically closed after 3 days. New replies are no longer allowed.